This is the mail archive of the
libc-alpha@sources.redhat.com
mailing list for the glibc project.
Re: [PATCH] ppc64 utmp changes
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Steve Munroe <sjmunroe at vnet dot ibm dot com>
- Cc: libc-alpha at sources dot redhat dot com, aj at suse dot de, geoffk at geoffk dot org, roland at frob dot com
- Date: Thu, 12 Sep 2002 19:14:29 +0200
- Subject: Re: [PATCH] ppc64 utmp changes
- References: <200209121707.g8CH7tQ19609@brule.rchland.ibm.com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Thu, Sep 12, 2002 at 12:07:55PM -0500, Steve Munroe wrote:
> +/* Powerpc needs this for combined 32/64-bit systems. This allows
> + struct utmp to be the same size in both modes. */
> +#if __WORDSIZE == 64
> +struct timeval32
> + {
> + __time32_t tv_sec; /* Seconds. */
> + __suseconds32_t tv_usec; /* Microseconds. */
> + };
> +#endif
I think this is a namespace problem, should be __timeval32 IMHO.
> +#if __WORDSIZE == 64
> + struct timeval32 ut_tv; /* Time entry was made. */
> +#else
> + struct timeval ut_tv; /* Time entry was made. */
> +#endif
> + __int32_t ut_addr_v6[4]; /* Internet address of remote host. */
> + char __unused[20]; /* Reserved for future use. */
Wonder if you shouldn't use further 32-bits from the __unused space
for upper 32-bits of ut_tv.tv_sec...
Jakub