This is the mail archive of the
libc-alpha@sources.redhat.com
mailing list for the glibc project.
Re: HAVE_HIDDEN doesnt always mean DONT_USE_BOOTSTRAP_MAP
- From: "Steve Munroe" <sjmunroe at us dot ibm dot com>
- To: Ulrich Drepper <drepper at redhat dot com>
- Cc: geoffk at geoffk dot org, libc-alpha at sources dot redhat dot com, roland at frob dot com
- Date: Mon, 26 Aug 2002 15:06:24 -0500
- Subject: Re: HAVE_HIDDEN doesnt always mean DONT_USE_BOOTSTRAP_MAP
Ulrich Drepper wrote:
> I think you've been told numerous times that using #ifs to test for
> architectures is wrong. Not only this, it's the single biggest sin.
Ok I will use __WORDSIZE and HAVE_ASM_GLOBAL_DOT_NAME where appropriate.
However I suspect that use of #ifdefs for architectures is not always a
sin. Two examples come to mind:
./stdlib/longlong.h
./sysdeps/unix/sysv/linux/kernel-features.h
Then there are the various forms of wordsize.h on architectures that
support both 32- and 64-bit. How else will __WORDSIZE get set correctly?
Are these the only exceptions?
> - - the patch is completely out-of-data and unnecessary anyhow
OK
> - - you still haven't corrected the ChangeLog format despite being told
to
Still fighting with my editor setting and learning when tabs are permitted
and not permitted.