This is the mail archive of the
libc-alpha@sources.redhat.com
mailing list for the glibc project.
Re: [PATCH] PowerPC64 port part 5 of 7
Ulrich Drepper <drepper@redhat.com> writes:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Andreas Jaeger wrote:
>
>> Do we want this consistency? I don't see why it's needed.
>
> If the symbol is not exported there is nothing to do.
They're not exported. Ok, then let's drop this part for good.
>
>
>>>2002-02-20 Steven Munroe <sjmunroe@us.ibm.com>
>>>
>>> * catgets/Makefile: Condition tests on $(build-shared)
>>> * iconv/Makefile: Condition tests on $(build-shared)
>>> * iconvdata/Makefile: Condition tests on $(build-shared)
>>> * libio/Makefile: Condition tests on $(build-shared)
>>> * localedata/Makefile: Condition tests on $(build-shared)
>>> * posix/Makefile: Condition tests on $(build-shared)
>>> * rt/Makefile: Condition tests on $(build-shared)
>>> * stdio-common/Makefile: Condition tests on $(build-shared)
>>> * time/Makefile: Condition tests on $(build-shared)
>>> * wcsmbs/Makefile: Condition tests on $(build-shared)
>>> Allow glibc configured with --disable-shared and before shared
>>> libraries are working, to run make check.
>> This looks fine to me.
>
> This is adding tons of duplication. Just add a separate "tests:" goal
> for the tests which need DSOs.
You mean like the appended patch?
>
>
>> Before committing I would clean up the patch (remove whitespace, fix
>> comments).
>
> It's not you who hasn't followed the rules...
I know but I considered helping to get this obvious patch in,
Andreas
============================================================
Index: time/Makefile
--- time/Makefile 9 Aug 2001 23:59:41 -0000 1.97
+++ time/Makefile 20 Aug 2002 08:24:41 -0000
@@ -1,4 +1,4 @@
-# Copyright (C) 1991-1999, 2000, 2001 Free Software Foundation, Inc.
+# Copyright (C) 1991-1999, 2000, 2001, 2002 Free Software Foundation, Inc.
# This file is part of the GNU C Library.
# The GNU C Library is free software; you can redistribute it and/or
@@ -32,7 +32,7 @@ routines := offtime asctime clock ctime
distribute := datemsk
-tests := test_time clocktest tst-posixtz tst-strptime tst_wcsftime \
+tests := test_time clocktest tst-posixtz tst-strptime \
tst-getdate tst-mktime
include ../Rules
@@ -51,3 +51,7 @@ tst-getdate-ENV= DATEMSK=datemsk TZDIR=$
test_time-ARGS= EST5EDT CST
tst-strptime-ENV = LOCPATH=${common-objpfx}localedata
+
+ifeq (yes,$(build-shared))
+tests: $(objpfx)tst_wcsftime.out
+endif
--
Andreas Jaeger
SuSE Labs aj@suse.de
private aj@arthur.inka.de
http://www.suse.de/~aj