This is the mail archive of the
libc-alpha@sources.redhat.com
mailing list for the glibc project.
Re: Does e2fsprogs-1.26 work on mips?
- From: "H . J . Lu" <hjl at lucon dot org>
- To: Andrew Morton <akpm at zip dot com dot au>
- Cc: tytso at thunk dot org, linux-mips at oss dot sgi dot com,linux kernel <linux-kernel at vger dot kernel dot org>,GNU C Library <libc-alpha at sources dot redhat dot com>
- Date: Sun, 24 Mar 2002 01:28:19 -0800
- Subject: Re: Does e2fsprogs-1.26 work on mips?
- References: <20020323140728.A4306@lucon.org> <3C9D1C1D.E30B9B4B@zip.com.au> <20020323221627.A10953@lucon.org> <3C9D7A42.B106C62D@zip.com.au>
On Sat, Mar 23, 2002 at 11:03:30PM -0800, Andrew Morton wrote:
> "H . J . Lu" wrote:
> >
> > ...
> > RLIM_INFINITY is not ((unsigned long)(~0UL)). Also you can't assume
> > the type of rlim.rlim_cur.
> >
> > Here is a patch.
> >
>
> I suspect it's not right.
>
> I don't pretend to understand the details, but they're
> messy. See Ted's recent words at
>
> http://www.uwsg.iu.edu/hypermail/linux/kernel/0203.2/0846.html
>
I look at the glibc code. It uses a constant RLIM_INFINITY for a given
arch. The user always passes (~0UL) to glibc on x86. glibc will check
if the kernel supports the new getrlimit at the run time. If it
doesn't, glibc will adjust the RLIM_INFINITY for setrlimit. I don't see
how glibc 2.2.5 compiled under kernel 2.2 will fail under 2.4 due to
this unless glibc is misconfigureed or miscompiled.
> (Sorry - I should have dug that message out earlier).
The problem is not all arches use (~0UL) for RLIM_INFINITY.
# cd linux/include
# grep RLIM_INFINITY asm-*/resource.h | grep define
asm-alpha/resource.h:#define RLIM_INFINITY 0x7ffffffffffffffful
asm-arm/resource.h:#define RLIM_INFINITY (~0UL)
asm-cris/resource.h:#define RLIM_INFINITY (~0UL)
asm-i386/resource.h:#define RLIM_INFINITY (~0UL)
asm-ia64/resource.h:#define RLIM_INFINITY (~0UL)
asm-m68k/resource.h:#define RLIM_INFINITY (~0UL)
asm-mips64/resource.h:#define RLIM_INFINITY (~0UL)
asm-mips/resource.h:#define RLIM_INFINITY 0x7fffffffUL
asm-parisc/resource.h:#define RLIM_INFINITY (~0UL)
asm-ppc/resource.h:#define RLIM_INFINITY (~0UL)
asm-s390/resource.h:#define RLIM_INFINITY (~0UL)
asm-s390x/resource.h:#define RLIM_INFINITY (~0UL)
asm-sh/resource.h:#define RLIM_INFINITY (~0UL)
asm-sparc64/resource.h:#define RLIM_INFINITY (~0UL)
asm-sparc/resource.h:#define RLIM_INFINITY 0x7fffffff
What should we do about it? I know e2fsprogs-1.26 doesn't work on mips
nor alpha because of this. I don't think it works on sparc.
BTW, mips has
/*
* SuS says limits have to be unsigned.
* Which makes a ton more sense anyway.
*/
#define RLIM_INFINITY 0x7fffffffUL
It doesn't make any senes.
H.J.