This is the mail archive of the
libc-alpha@sources.redhat.com
mailing list for the glibc project.
Re: PATCH: Re: Do we really want to use i586 code for i686?
On Sun, Nov 11, 2001 at 04:55:21PM -0800, H . J . Lu wrote:
> On Sun, Nov 11, 2001 at 08:59:25AM -0800, H . J . Lu wrote:
> > sysdeps/i386/i686/Implies says:
> >
> > # Due to the reordering and the oher nifty extensions in the i686 it is
> > # not really good to use heavily i586 optimized code on a i686. It's
> > # better to use i486/i386 code.
> > i386/i486
> >
> > But I got:
> >
> >
> > I think the problem may be linuxthreads/sysdeps/i386/i686/Implies:
> >
> > i386/i586
> >
> >
>
> How about this patch?
>
>
> H.J.
> ----
> 2001-11-11 H.J. Lu <hjl@gnu.org>
>
> * configure.in: Limit addon's Implies to addon only.
> * configure: Rebuild.
>
> --- configure.in.addon Sun Nov 11 16:45:00 2001
> +++ configure.in Sun Nov 11 16:45:11 2001
> @@ -799,7 +799,7 @@ while test $# -gt 0; do
> implied="$implied $name_base/$x";
> found=yes
> fi
> - for d in $add_ons_pfx ''; do
> + for d in $add_ons_pfx; do
> try="${d}sysdeps/$x"
> case $d in
> /*) try_srcdir= ;;
I don't think we should apply Implies outside of the subdirectory.
Here is a new patch. That is A implies B in libc doesn't mean A implies
B in linuxthreads, vice versa.
H.J.
---
2001-11-12 H.J. Lu <hjl@gnu.org>
* configure.in: Don't expand Implies outside of the
subdirectory.
* configure: Rebuild.
--- configure.in.addon Wed Aug 29 11:48:49 2001
+++ configure.in Sun Nov 11 23:43:46 2001
@@ -508,20 +508,6 @@ while test $# -gt 0; do
implied="$implied $name_base/$x";
found=yes
fi
- for d in $add_ons_pfx ''; do
- try="${d}sysdeps/$x"
- case $d in
- /*) try_srcdir= ;;
- *) try_srcdir=$srcdir/ ;;
- esac
- test -n "$enable_debug_configure" &&
- echo "[DEBUG]: $name implied $x try($d) {$try_srcdir}$try" >&2
- if test $try != $xsrcdir$name_base/$x && test -d $try_srcdir$try;
- then
- implied="$implied $try"
- found=yes
- fi
- done
if test $found = no; then
AC_MSG_WARN($name/Implies specifies nonexistent $x)
fi