This is the mail archive of the libc-alpha@sources.redhat.com mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: glibc-2.2.4pre2 results


Franz Sirl <Franz.Sirl-kernel@lauterbach.com> writes:

> glibc-2.2.4pre compiles and tests fine on PPC in all combinations:
>
> - compiled with gcc-2.95.4cvs or gcc-3.0.1cvs
> - with and without Jakub's latest gcc-3.0 patch
>
> A few build warnings though:
> make[2]: Entering directory `/home/fsirl/rh70/glibc/BUILD/glibc-2.2.4/iconv'
> gconv_charset.h:51: warning: `upstr' defined but not used
> gconv_charset.h:51: warning: `upstr' defined but not used
> gconv_charset.h:51: warning: `upstr' defined but not used
> make[2]: Leaving directory `/home/fsirl/rh70/glibc/BUILD/glibc-2.2.4/iconv'
> ...
> make[2]: Entering directory `/home/fsirl/rh70/glibc/BUILD/glibc-2.2.4/libio'
> iopopen.c:116: warning: `unlock' defined but not used
> iopopen.c:116: warning: `unlock' defined but not used
> oldiopopen.c:117: warning: `unlock' defined but not used
> iopopen.c:116: warning: `unlock' defined but not used
> make[2]: Leaving directory `/home/fsirl/rh70/glibc/BUILD/glibc-2.2.4/libio'

thanks.

Here's a patch.  

Ok to commit?

Andreas


2001-08-07  Andreas Jaeger  <aj@suse.de>

	* iconv/gconv_charset.h (upstr): Add unused attribute to avoid
	warning.

	* libio/iopopen.c (_IO_new_proc_open): Fix typos, it's
	_IO_MTSAFE_IO.
	(_IO_new_proc_close): Likewise.
	* libio/oldiopopen.c (_IO_old_proc_open): Likewise.
	(_IO_old_proc_close): Likewise.

============================================================
Index: iconv/gconv_charset.h
--- iconv/gconv_charset.h	2001/07/27 17:27:57	1.3
+++ iconv/gconv_charset.h	2001/08/07 09:11:39
@@ -46,7 +46,7 @@ strip (char *wp, const char *s)
 }
 
 
-static char *
+static char * __attribute__ ((unused))
 upstr (char *dst, const char *str)
 {
   char *cp = dst;
============================================================
Index: libio/iopopen.c
--- libio/iopopen.c	2001/07/31 19:18:18	1.24
+++ libio/iopopen.c	2001/08/07 09:11:39
@@ -182,13 +182,13 @@ _IO_new_proc_open (fp, command, mode)
   _IO_fileno (fp) = parent_end;
 
   /* Link into proc_file_chain. */
-#ifdef _IO_MTSFE_IO
+#ifdef _IO_MTSAFE_IO
   _IO_cleanup_region_start_noarg (unlock);
   _IO_lock_lock (proc_file_chain_lock);
 #endif
   ((_IO_proc_file *) fp)->next = proc_file_chain;
   proc_file_chain = (_IO_proc_file *) fp;
-#ifdef _IO_MTSFE_IO
+#ifdef _IO_MTSAFE_IO
   _IO_lock_unlock (proc_file_chain_lock);
   _IO_cleanup_region_end (0);
 #endif
@@ -247,7 +247,7 @@ _IO_new_proc_close (fp)
   int status = -1;
 
   /* Unlink from proc_file_chain. */
-#ifdef _IO_MTSFE_IO
+#ifdef _IO_MTSAFE_IO
   _IO_cleanup_region_start_noarg (unlock);
   _IO_lock_lock (proc_file_chain_lock);
 #endif
@@ -260,7 +260,7 @@ _IO_new_proc_close (fp)
 	  break;
 	}
     }
-#ifdef _IO_MTSFE_IO
+#ifdef _IO_MTSAFE_IO
   _IO_lock_unlock (proc_file_chain_lock);
   _IO_cleanup_region_end (0);
 #endif

-- 
 Andreas Jaeger
  SuSE Labs aj@suse.de
   private aj@arthur.inka.de
    http://www.suse.de/~aj


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]