This is the mail archive of the libc-alpha@sources.redhat.com mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Patch(?): glibc-cvs/{configure.in,aclocal.m4} autoconf-2.52 partial support


"Adam J. Richter" <adam@yggdrasil.com> writes:

|> --- libc/aclocal.m4	Mon Jun 11 05:32:44 2001
|> +++ /usr/src/lib/glibc/aclocal.m4	Tue Jul 31 03:14:57 2001
|> @@ -66,22 +66,26 @@
|>  dnl In the situation that cross-linking is impossible, the variable
|>  dnl `cross_linkable' will be substituted with "yes".
|>  dnl The vercheck macros are expected to have been called already.
|> -AC_DEFUN(AC_PROG_CC_LOCAL,
|> +AC_DEFUN([AC_PROG_CC_LOCAL],
|>  [AC_BEFORE([$0], [AC_PROG_CPP])dnl
|>  
|>  AC_PROG_CC_WORKS_LOCAL
|> -AC_PROG_CC_GNU
|> +AC_PROG_CC

AC_PROG_CC_GNU is now called _AC_PROG_COMPILER_GNU.  IMHO with autoconf
2.52 the AC_PROG_CC_LOCAL hack is not necessary.  Instead I would just use
AC_PROG_CC and add this to aclocal.m4:

define([_AC_COMPILER_EXEEXT], [EXEEXT=
])

while removing AC_PROG_CC_LOCAL and AC_PROG_CC_WORKS_LOCAL.

|> --- libc/configure.in	Mon Jul  9 04:51:53 2001
|> +++ /usr/src/lib/glibc/configure.in	Tue Jul 31 05:09:37 2001
|> @@ -571,8 +571,13 @@
|>    AC_MSG_ERROR(*** A pwd binary could not be found.)
|>  fi
|>  
|> +AC_DEFUN(REQUIRE_AC_CHECK_TOOL_PREFIX, [
|> +	AC_REQUIRE([AC_CHECK_TOOL_PREFIX])])
|> +AC_DEFUN(REQUIRE_LIBC_KERNEL_ID, [
|> +	AC_REQUIRE([LIBC_KERNEL_ID])])
|> +
|>  # These programs are version sensitive.
|> -AC_REQUIRE([AC_CHECK_TOOL_PREFIX])dnl
|> +REQUIRE_AC_CHECK_TOOL_PREFIX

This AC_REQUIRE stuff should go.  There is no sense in using AC_REQUIRE at
toplevel, just use the macro unconditionally.

|> @@ -628,6 +637,13 @@
|>  CCVERSION=`$CC -v 2>&1 | sed -n 's/gcc version //p'`
|>  AC_SUBST(CCVERSION)
|>  
|> +AC_CHECK_LIB(loginstall, log_event_with_source,
|> +             AC_DEFINE(HAVE_LIBLOGINSTALL)
|> +             LIBLOGINSTALL="-lloginstall",
|> +             LIBLOGINSTALL=""
|> +            )
|> +AC_SUBST(LIBLOGINSTALL)
|> +

This does not belong here.

|> @@ -1453,7 +1517,7 @@
|>  ])dnl
|>  
|>    AC_CACHE_CHECK(OS release for uname, libc_cv_uname_release, [dnl
|> -AC_REQUIRE([LIBC_KERNEL_ID])dnl
|> +REQUIRE_LIBC_KERNEL_ID()dnl

Don't AC_REQUIRE, just use it.

Andreas.

-- 
Andreas Schwab                                  "And now for something
SuSE Labs                                        completely different."
Andreas.Schwab@suse.de
SuSE GmbH, Schanzäckerstr. 10, D-90443 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]