This is the mail archive of the libc-alpha@sources.redhat.com mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: i386 fpu function rewrite


Jakub Jelinek <jakub@redhat.com> writes:

> On Sat, May 05, 2001 at 08:08:30PM +0200, Andreas Jaeger wrote:
> >   asm ("fld	%%st			/* x : x */
> > 	fmul	%%st(0)			/* x^2 : x */
> > 	fld1				/* 1 : x^2 : x */
> > 	fsubp				/* 1 - x^2 : x */
> > 	fsqrt				/* sqrt (1 - x^2) : x */
> > 	fxch	%%st(1)			/* x : sqrt (1 - x^2) */
> > 	fpatan				/* atan (sqrt(1 - x^2) / x) */"
> >        : "=t" (res) : "0" (x) : "st(1)");
> 
> Now that gcc deprecates multi-line string literals you probably should either
> use \n\ or make it a bunch of one line strings contatenated together.

I noticed this already and will add this in my real patch.  For now I
just like to hear that such a rewrite is acceptable and if there's
anything I should take care of.

Thanks,
Andreas
-- 
 Andreas Jaeger
  SuSE Labs aj@suse.de
   private aj@arthur.inka.de
    http://www.suse.de/~aj


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]