This is the mail archive of the
libc-alpha@sources.redhat.com
mailing list for the glibc project.
Re: [patch:] iconv/gconv.c: Don't refer to parameter cd before testing for validity.
- To: Hans-Peter Nilsson <hans-peter dot nilsson at axis dot com>
- Subject: Re: [patch:] iconv/gconv.c: Don't refer to parameter cd before testing for validity.
- From: Ulrich Drepper <drepper at redhat dot com>
- Date: 08 Apr 2001 20:54:28 -0700
- Cc: libc-alpha at sources dot redhat dot com
- References: <200104090119.DAA12428@ignucius.axis.se>
- Reply-To: drepper at cygnus dot com (Ulrich Drepper)
Hans-Peter Nilsson <hans-peter.nilsson@axis.com> writes:
> If parameter cd can be (__gconv_t) -1L, then I guess it shouldn't be
> accessed before checked.
Well, I don't know why I added the test in the first place. But now
that it's there your patch is OK. I've applied it. Thanks,
--
---------------. ,-. 1325 Chesapeake Terrace
Ulrich Drepper \ ,-------------------' \ Sunnyvale, CA 94089 USA
Red Hat `--' drepper at redhat.com `------------------------