This is the mail archive of the
libc-alpha@sources.redhat.com
mailing list for the glibc project.
Are you sure this change is ok?
- To: Ulrich Drepper <drepper at cygnus dot com>
- Subject: Are you sure this change is ok?
- From: "H . J . Lu" <hjl at valinux dot com>
- Date: Tue, 13 Feb 2001 20:30:03 -0800
- Cc: GNU C Library <libc-alpha at sourceware dot cygnus dot com>
Ulrich,
I believe you checked in the following patch. Are you sure it is
100% correct? Especially
- idx[cnt - 2] = idx[cnt - 3] + iov[cnt - 1].iov_len;
+ idx[cnt - 2] = idx[cnt - 2] + iov[cnt - 1].iov_len;
LC_PAPER failed on ia64 now. The similar code is almost all
locale/programs/ld-*.c. Why did you only change ld-paper.c?
--
H.J. Lu (hjl@valinux.com)
--
2001-02-13 Ulrich Drepper <drepper@redhat.com>
* locale/programs/ld-paper.c (paper_output): Pretty printing.
Index: locale/programs/ld-paper.c
===================================================================
RCS file: /work/cvs/gnu/glibc/locale/programs/ld-paper.c,v
retrieving revision 1.1.1.3
retrieving revision 1.1.1.4
diff -u -p -r1.1.1.3 -r1.1.1.4
--- locale/programs/ld-paper.c 2001/02/06 23:27:32 1.1.1.3
+++ locale/programs/ld-paper.c 2001/02/14 03:30:53 1.1.1.4
@@ -133,12 +133,12 @@ paper_output (struct localedef_t *locale
iov[cnt].iov_len = sizeof (idx);
++cnt;
- idx[cnt - 2] = iov[0].iov_len + iov[1].iov_len;
+ idx[cnt - 2] = iov[cnt - 2].iov_len + iov[cnt - 1].iov_len;
iov[cnt].iov_base = &paper->height;
iov[cnt].iov_len = 4;
++cnt;
- idx[cnt - 2] = idx[cnt - 3] + iov[cnt - 1].iov_len;
+ idx[cnt - 2] = idx[cnt - 2] + iov[cnt - 1].iov_len;
iov[cnt].iov_base = &paper->width;
iov[cnt].iov_len = 4;
++cnt;