Re: iconv make check failures under ppc

[Franz Sirl <Franz dot Sirl-kernel at lauterbach dot com>]

On Sat, 09 Sep 2000, Kevin B. Hendricks wrote:
> Hi Franz,
>
> I used your 2.1.93 src.rpm and all of my make check failures went away!
>
> I then went and diff'd the two source trees (Friday morning cvs freshly
> checked out into a clean directory by me versus yours and the only
> differnce I found was the following:
>
> diff -urN glibc-2.1.93/sysdeps/powerpc/dl-machine.c
> /usr/local/src/libc/sysdeps/powerpc/dl-machine.c
> --- glibc-2.1.93/sysdeps/powerpc/dl-machine.c   Sun Aug 27 00:22:03 2000
> +++ /usr/local/src/libc/sysdeps/powerpc/dl-machine.c    Mon Jun 12 03:13:21
> 2000@@ -71,10 +71,10 @@
>  #define OPCODE_SLWI(ra,rs,sh) OPCODE_RLWINM(ra,rs,sh,0,31-sh)
>
>
> -#define PPC_DCBST(where) asm volatile ("dcbst 0,%0" : : "r"(where) :
> "memory") -#define PPC_SYNC asm volatile ("sync" : : : "memory")
> +#define PPC_DCBST(where) asm ("dcbst 0,%0" : : "r"(where) : "memory")
> +#define PPC_SYNC asm ("sync" : : : "memory")
>  #define PPC_ISYNC asm volatile ("sync; isync" : : : "memory")
> -#define PPC_ICBI(where) asm volatile ("icbi 0,%0" : : "r"(where) :
> "memory") +#define PPC_ICBI(where) asm ("icbi 0,%0" : : "r"(where) :
> "memory") #define PPC_DIE asm volatile ("tweq 0,0")
>
>  /* Use this when you've modified some code, but it won't be in the
>
>
> Your version of dl-machine.c seems to be actually newer than mine (and
> yours has the required "volatile" tag to prevent things from being
> re-ordered by the compiler).  Mine is dated Jun 12 and yours is dated
> August 27.
>
> I have no idea why a *fresh* anonymous cvs checkout on Friday morning would
> give me a file older than what you already have.
>
> Is the anonymous cvs server not completely up to date?  Should I be doing
> checkouts from a differnt tree or a different way?
>
> This is very confusing.  I am just glad your version passes make check on
> my machine and now I can run the jdk testsuite to really give linuxthreads
> a good testing.

Oops, I totally forgot about this patch. It's in my source trees since I was 
tracking down the apache DSO bug a while ago. At that time it made no 
difference for  me though.

When the glibc CVS is up again, I'll make a diff and post the patch. Thanks 
for tracking this down.

Franz.