This is the mail archive of the libc-alpha@sources.redhat.com mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [PATCH] Fix recent fmemopen breakage


>>>>> Franz Sirl writes:

 > Hi,
 > the last change to fmemopen.c is a bit optimistic, it's not OK to free mem we 
 > didn't allocate, it may be a static buffer. The patch makes the testsuite 
 > happy again.

 > Also included a small linuxthreads warning fix, it may be the wrong solution 
 > though, cause I find it a bit strange that testandset and __comapare_and_swap 
 > take differing kind of pointers.

 > Franz.

 > 	* libio/fmemopen.c (fmemopen_close): Don't free buffer if we didn't allocate 
 > 	it.
I've added this one already myself (same patch as yours).

 > 	* linuxthreads/spinlock.h: Warning fix.
Uli has to comment on this,

Thanks,
Andreas
-- 
 Andreas Jaeger
  SuSE Labs aj@suse.de
   private aj@arthur.inka.de
    http://www.suse.de/~aj

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]