This is the mail archive of the
libc-alpha@sourceware.cygnus.com
mailing list for the glibc project.
Re: glibc 2.1.91 (first test release for 2.2)
On Mon, Jul 03, 2000 at 08:02:09PM -0700, Ulrich Drepper wrote:
> "H . J . Lu" <hjl@lucon.org> writes:
>
> > There seem some bugs in locale stuff. I am working on them. It may
> > take a while to figure them out.
>
> There certainly can be some problems in there, much has changed. But
> it makes no sense to say "there are bugs" and not giving details.
> Besides, if you can describe it I'll most likely be able to say what
> the problem is.
>
> Also: you must distinguish between problems in the code and those
> arising from using old data and conversion modules.
>
I have no idea how ctype_output will work for anyone. It certainly
doesn't work for me. If you can take a close look, you will find
struct iovec iov[2 + nelems + ctype->nr_charclass
+ ctype->map_collection_nr + 2];
write_locale_data (output_path, "LC_CTYPE", 2 + elem + offset + 2, iov);
will write 2 elements of junks.
I have to unset LANG since mine is to en_US. If I don't unset it, the
test programs will read files under /usr/share/locale/en_US. Also we
may want to unset LANG for tests where any locale is used for any
reason.
----
2000-07-03 H.J. Lu <hjl@gnu.org>
* locale/programs/ld-ctype.c (ctype_output): The size of iov
is 2 + elem + offset, not 2 + elem + offset + 2.
* localedata/tst-fmon.sh: Set LANG to "".
* localedata/tst-locale.sh: Likewise.
* intl/tst-gettext.sh: Likewise.
Index: locale/programs/ld-ctype.c
===================================================================
RCS file: /work/cvs/gnu/glibc/locale/programs/ld-ctype.c,v
retrieving revision 1.1.1.5
diff -u -p -r1.1.1.5 ld-ctype.c
--- locale/programs/ld-ctype.c 2000/07/01 19:22:03 1.1.1.5
+++ locale/programs/ld-ctype.c 2000/07/04 04:55:21
@@ -1142,7 +1142,7 @@ ctype_output (struct localedef_t *locale
assert (2 + elem + offset == (nelems + ctype->nr_charclass
+ ctype->map_collection_nr + 2 + 2));
- write_locale_data (output_path, "LC_CTYPE", 2 + elem + offset + 2, iov);
+ write_locale_data (output_path, "LC_CTYPE", 2 + elem + offset, iov);
}
Index: localedata/tst-fmon.sh
===================================================================
RCS file: /work/cvs/gnu/glibc/localedata/tst-fmon.sh,v
retrieving revision 1.1.1.4
diff -u -p -r1.1.1.4 tst-fmon.sh
--- localedata/tst-fmon.sh 2000/07/03 22:49:56 1.1.1.4
+++ localedata/tst-fmon.sh 2000/07/04 04:42:34
@@ -36,7 +36,7 @@ for cns in `cd ./tst-fmon-locales && ls
cn=tst-fmon-locales/$cns
fn=charmaps/ISO-8859-1
I18NPATH=. GCONV_PATH=${common_objpfx}iconvdata \
- LOCPATH=${common_objpfx}localedata LANGUAGE=C \
+ LOCPATH=${common_objpfx}localedata LANGUAGE=C LANG= \
${common_objpfx}elf/ld.so --library-path $common_objpfx \
${common_objpfx}locale/localedef \
--quiet -i $cn -f $fn ${common_objpfx}localedata/$cns
Index: localedata/tst-locale.sh
===================================================================
RCS file: /work/cvs/gnu/glibc/localedata/tst-locale.sh,v
retrieving revision 1.1.1.3
diff -u -p -r1.1.1.3 tst-locale.sh
--- localedata/tst-locale.sh 2000/07/03 22:49:56 1.1.1.3
+++ localedata/tst-locale.sh 2000/07/04 04:42:25
@@ -31,7 +31,7 @@ test_locale ()
rep="--repertoire-map $rep"
fi
I18NPATH=. GCONV_PATH=${common_objpfx}iconvdata \
- LOCPATH=${common_objpfx}localedata LANGUAGE=C \
+ LOCPATH=${common_objpfx}localedata LANGUAGE=C LANG= \
${common_objpfx}elf/ld.so --library-path $common_objpfx \
${common_objpfx}locale/localedef --quiet -c -f $charmap -i $input \
${rep} ${common_objpfx}localedata/$out
Index: intl/tst-gettext.sh
===================================================================
RCS file: /work/cvs/gnu/glibc/intl/tst-gettext.sh,v
retrieving revision 1.1.1.3
diff -u -p -r1.1.1.3 tst-gettext.sh
--- intl/tst-gettext.sh 2000/06/25 15:58:01 1.1.1.3
+++ intl/tst-gettext.sh 2000/07/04 05:03:06
@@ -25,6 +25,8 @@ GCONV_PATH=${common_objpfx}iconvdata
export GCONV_PATH
LOCPATH=${common_objpfx}localedata
export LOCPATH
+LANG=
+export LANG
# Generate the test data.
test -d ${objpfx}domaindir || mkdir ${objpfx}domaindir