Re: [RFA] Memory Preferences Now Permanent

[Fernando Nasser <fnasser at cygnus dot com>]

Syd Polk wrote:
> 
> At 08:30 PM 11/3/00 -0500, Larry Smith wrote:
> 
> >This patch adds code to save and restore the preferences selected
> >in displaying memory, and fixes a bug that prevented one from
> >changing the color of the memory display window.
> >
> >2000-11-03  Larry Smith  <lsmith@redhat.com>
> >         * mempref.itb (constructor): Added code to retrieve
> >         memory display preferences.
> >         * mempref.itb (build_win): Added code to retrieve
> >         memory display preferences, corrected bug preventing
> >         display of color background preference for memory display.
> >         * mempref.itb (apply): Added code to save new preferences.
> >         * memwin.itb (buildwin): added retrieval of memory display
> >         preferences
> >         * prefs.tcl (pref_save): added new memory section for memory
> >         display preferences.
> >         * prefs.tcl (pref_set_defaults): added defaults for new memory
> >         section
> 
> Style nits.
> 
> With the above fixes, I would approve this.
> 

I don't know why we didn't store those preferences.  I tried to think
of a reason but I couldn't.

So I also agree with the changes (after the fixed noted by Syd).

Thanks again.


-- 
Fernando Nasser
Red Hat Canada Ltd.                     E-Mail:  fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario   M4P 2C9