[glibc/azanella/clang] i386: Move ___tls_get_addr hidden proto before its first usage

Adhemerval Zanella azanella@sourceware.org
Thu Sep 28 17:52:39 GMT 2023


https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=b8803472215105b8e0919fc566ab72ea68e3b265

commit b8803472215105b8e0919fc566ab72ea68e3b265
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date:   Tue Jul 26 08:41:10 2022 -0300

    i386: Move ___tls_get_addr hidden proto before its first usage
    
    clang can not apply asm redirections to functions after these
    functions are used for the first time.

Diff:
---
 sysdeps/i386/dl-tls.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sysdeps/i386/dl-tls.h b/sysdeps/i386/dl-tls.h
index ec7678096b..ac46abdbef 100644
--- a/sysdeps/i386/dl-tls.h
+++ b/sysdeps/i386/dl-tls.h
@@ -31,6 +31,8 @@ extern void *___tls_get_addr (tls_index *ti)
      __attribute__ ((__regparm__ (1)));
 extern void *___tls_get_addr_internal (tls_index *ti)
      __attribute__ ((__regparm__ (1))) attribute_hidden;
+rtld_hidden_proto (___tls_get_addr)
+rtld_hidden_def (___tls_get_addr)
 
 # if IS_IN (rtld)
 /* The special thing about the x86 TLS ABI is that we have two
@@ -50,8 +52,6 @@ __tls_get_addr (tls_index *ti)
    version of this file.  */
 # define __tls_get_addr __attribute__ ((__regparm__ (1))) ___tls_get_addr
 strong_alias (___tls_get_addr, ___tls_get_addr_internal)
-rtld_hidden_proto (___tls_get_addr)
-rtld_hidden_def (___tls_get_addr)
 #else
 
 /* Users should get the better interface.  */


More information about the Glibc-cvs mailing list