This is the mail archive of the glibc-cvs@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

GNU C Library master sources branch master updated. glibc-2.26.9000-1251-g650ba77


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  650ba77ad547b24e0839c90ed56f7b9445d8165a (commit)
      from  d9f442ce56a716ef4723a05ba913c5e2e78d3096 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://sourceware.org/git/gitweb.cgi?p=glibc.git;a=commitdiff;h=650ba77ad547b24e0839c90ed56f7b9445d8165a

commit 650ba77ad547b24e0839c90ed56f7b9445d8165a
Author: Il'ya Malakhov <ilmalakhov@yandex.ru>
Date:   Wed Jan 31 14:32:19 2018 -0800

    crypt: Fix badsalttest test (Bug 22765)
    
    The value of 'cd.initialized' is left uninitialized before the
    first invocation of 'crypt_r ()' in this test despite the fact
    that it should be set to zero according to the API.
    
    Reviewed-by: Carlos O'Donell <carlos@redhat.com>

diff --git a/ChangeLog b/ChangeLog
index b2cec4f..a5847a5 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2018-01-31  Il'ya Malakhov  <ilmalakhov@yandex.ru>
+
+	[BZ #22765]
+	* crypt/badsalttest.c (do_test): Set cd.initialized to 0.
+
 2018-01-31  Dmitry V. Levin  <ldv@altlinux.org>
 
 	* manual/install.texi (Tools for Compilation): Update the newest
diff --git a/crypt/badsalttest.c b/crypt/badsalttest.c
index 6c5230c..3e57cdd 100644
--- a/crypt/badsalttest.c
+++ b/crypt/badsalttest.c
@@ -61,6 +61,9 @@ do_test (void)
       tests[n - 1][1] = &page[pagesize - 1];
     }
 
+  /* Mark cd as initialized before first call to crypt_r.  */
+  cd.initialized = 0;
+
   for (size_t i = 0; i < n; i++)
     {
       if (crypt (tests[i][0], tests[i][1]))

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog           |    5 +++++
 crypt/badsalttest.c |    3 +++
 2 files changed, 8 insertions(+), 0 deletions(-)


hooks/post-receive
-- 
GNU C Library master sources


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]