GNU C Library master sources branch master updated. glibc-2.26.9000-939-g1dbe6f6

[jsm28 at sourceware dot org]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  1dbe6f64ab982a1a3258948e9347b5bca76790f3 (commit)
      from  53994f12633b863eb833fc3b1f6971ae8de61ff8 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://sourceware.org/git/gitweb.cgi?p=glibc.git;a=commitdiff;h=1dbe6f64ab982a1a3258948e9347b5bca76790f3

commit 1dbe6f64ab982a1a3258948e9347b5bca76790f3
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Wed Dec 6 15:19:06 2017 +0000

    Don't make local variables static in ldbl-96 j1l.
    
    The ldbl-96 implementation of j1l has some function-local variables
    that are declared static for no apparent reason (this dates back to
    the first addition of that file).
    
    Any vaguely recent compiler, probably including any that are supported
    for building glibc, optimizes away the "static" here, as the values of
    the variables on entry to the function are dead.  So there is not
    actually a user-visible bug here at present (but with any compilers
    that didn't optimize away the static at all, possibly building with
    less or no optimization, so that the function stored intermediate
    values to and then loaded them from the variables, there would have
    been a thread-safety issue).  But the "static" clearly doesn't belong
    there and might potentially make things unsafe were compilation
    without optimization to be supported in future, so this patch removes
    it.
    
    Tested for x86_64.
    
    	* sysdeps/ieee754/ldbl-96/e_j1l.c (qone): Don't make local
    	variables static.

diff --git a/ChangeLog b/ChangeLog
index 7850a15..eda9c0c 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,8 @@
 2017-12-06  Joseph Myers  <joseph@codesourcery.com>
 
+	* sysdeps/ieee754/ldbl-96/e_j1l.c (qone): Don't make local
+	variables static.
+
 	* sysdeps/ieee754/ldbl-128/e_j0l.c (Y0_2N): Make const.
 	(Y0_2D): Likewise.
 	* sysdeps/ieee754/ldbl-128/e_j1l.c (Y0_2N): Likewise.
diff --git a/sysdeps/ieee754/ldbl-96/e_j1l.c b/sysdeps/ieee754/ldbl-96/e_j1l.c
index a8a9902..4f07b0b 100644
--- a/sysdeps/ieee754/ldbl-96/e_j1l.c
+++ b/sysdeps/ieee754/ldbl-96/e_j1l.c
@@ -507,7 +507,7 @@ static long double
 qone (long double x)
 {
   const long double *p, *q;
-  static long double s, r, z;
+  long double s, r, z;
   int32_t ix;
   uint32_t se, i0, i1;
 

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                       |    3 +++
 sysdeps/ieee754/ldbl-96/e_j1l.c |    2 +-
 2 files changed, 4 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
GNU C Library master sources