This is the mail archive of the
glibc-cvs@sourceware.org
mailing list for the glibc project.
GNU C Library master sources branch master updated. glibc-2.25-432-g6c85cc2
- From: siddhesh at sourceware dot org
- To: glibc-cvs at sourceware dot org
- Date: 9 Jun 2017 08:56:22 -0000
- Subject: GNU C Library master sources branch master updated. glibc-2.25-432-g6c85cc2
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".
The branch, master has been updated
via 6c85cc2852367ea2db91ff6a1fc0f6fc0653788d (commit)
from ab70273bb7b0d4b20325560eba1fd3777d7e5f11 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://sourceware.org/git/gitweb.cgi?p=glibc.git;a=commitdiff;h=6c85cc2852367ea2db91ff6a1fc0f6fc0653788d
commit 6c85cc2852367ea2db91ff6a1fc0f6fc0653788d
Author: Siddhesh Poyarekar <siddhesh@sourceware.org>
Date: Fri Jun 9 14:18:11 2017 +0530
aarch64: Fix undefined behavior in _dl_procinfo
1 << 31 is undefined, so replace it with a cleaner check. Also remove
magic numbers in comments.
* sysdeps/unix/sysv/linux/aarch64/dl-procinfo.h: Remove
mention of magic numbers in comments.
(_dl_procinfo): Fix undefined behavior
diff --git a/ChangeLog b/ChangeLog
index 6c6ff13..006e7ac 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2017-06-09 Siddhesh Poyarekar <siddhesh@sourceware.org>
+
+ * sysdeps/unix/sysv/linux/aarch64/dl-procinfo.h: Remove
+ mention of magic numbers in comments.
+ (_dl_procinfo): Fix undefined behavior
+
2017-06-08 Joseph Myers <joseph@codesourcery.com>
* conform/data/sys/wait.h-data (WIFCONTINUED): Do not expect for
diff --git a/sysdeps/unix/sysv/linux/aarch64/dl-procinfo.h b/sysdeps/unix/sysv/linux/aarch64/dl-procinfo.h
index cdb36d3..04fc6be 100644
--- a/sysdeps/unix/sysv/linux/aarch64/dl-procinfo.h
+++ b/sysdeps/unix/sysv/linux/aarch64/dl-procinfo.h
@@ -40,7 +40,7 @@ _dl_procinfo (unsigned int type, unsigned long int word)
_dl_printf ("AT_HWCAP: ");
for (i = 0; i < 32; ++i)
- if (word & (1 << i))
+ if ((word >> i) & 1)
_dl_printf (" %s", GLRO(dl_aarch64_cap_flags)[i]);
_dl_printf ("\n");
@@ -56,10 +56,10 @@ _dl_hwcap_string (int idx)
};
-/* 13 HWCAP bits set. */
+/* Number of HWCAP bits set. */
#define _DL_HWCAP_COUNT 13
-/* Low 13 bits are allocated in HWCAP. */
+/* Offset of the last bit allocated in HWCAP. */
#define _DL_HWCAP_LAST 12
/* HWCAP_CPUID should be available by default to influence IFUNC as well as
-----------------------------------------------------------------------
Summary of changes:
ChangeLog | 6 ++++++
sysdeps/unix/sysv/linux/aarch64/dl-procinfo.h | 6 +++---
2 files changed, 9 insertions(+), 3 deletions(-)
hooks/post-receive
--
GNU C Library master sources