This is the mail archive of the
glibc-cvs@sourceware.org
mailing list for the glibc project.
GNU C Library master sources branch master updated. glibc-2.24-281-g0f04fc0
- From: jsm28 at sourceware dot org
- To: glibc-cvs at sourceware dot org
- Date: 20 Oct 2016 23:26:00 -0000
- Subject: GNU C Library master sources branch master updated. glibc-2.24-281-g0f04fc0
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".
The branch, master has been updated
via 0f04fc07f6a36e761ec76100043798ea5c7a590c (commit)
from 05f3ed0a799d08c2b3ecc256fc0dc08d8b9a3784 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://sourceware.org/git/gitweb.cgi?p=glibc.git;a=commitdiff;h=0f04fc07f6a36e761ec76100043798ea5c7a590c
commit 0f04fc07f6a36e761ec76100043798ea5c7a590c
Author: Joseph Myers <joseph@codesourcery.com>
Date: Thu Oct 20 23:24:44 2016 +0000
Use VSQRT instruction for ARM sqrt (bug 20660).
This patch makes ARM sqrt and sqrtf use the VSQRT VFP square root
instruction when available, instead of much larger generic code for
computing square roots.
Now, GCC will normally inline sqrt calls except for negative arguments
where errno needs to be set, and because the benchtests fail to use
-fno-builtin that means no significant difference in benchmark results
for sqrt (note, however, there are lots of __ieee754_sqrt calls
internally in libm, which are *not* inlined - although some
architectures define __ieee754_sqrt in their math_private.h for that
purpose, ARM doesn't - so improving out-of-line sqrt performance is
still relevant to those other functions, if not for most ordinary
direct users of sqrt). With the benchtests changed to use
-fno-builtin for sqrt tests, typical performance results before the
change are ("max" is wildly varying in any case):
"duration": 9.88358e+09,
"iterations": 4.8783e+07,
"max": 457.764,
"min": 183.105,
"mean": 202.603
and after it are:
"duration": 9.45663e+09,
"iterations": 2.24385e+08,
"max": 274.659,
"min": 30.517,
"mean": 42.1447
Tested for ARM (hard-float and soft-float).
[BZ #20660]
* sysdeps/arm/e_sqrt.c: New file.
* sysdeps/arm/e_sqrtf.c: Likewise.
diff --git a/ChangeLog b/ChangeLog
index 49436bc..ef710b4 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2016-10-20 Joseph Myers <joseph@codesourcery.com>
+
+ [BZ #20660]
+ * sysdeps/arm/e_sqrt.c: New file.
+ * sysdeps/arm/e_sqrtf.c: Likewise.
+
2016-10-19 Joseph Myers <joseph@codesourcery.com>
[BZ #20718]
diff --git a/sysdeps/arm/e_sqrt.c b/sysdeps/arm/e_sqrt.c
new file mode 100644
index 0000000..8ba85ed
--- /dev/null
+++ b/sysdeps/arm/e_sqrt.c
@@ -0,0 +1,45 @@
+/* Compute square root for double. ARM version.
+ Copyright (C) 2016 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <http://www.gnu.org/licenses/>. */
+
+#ifdef __SOFTFP__
+
+/* Use architecture-indendent sqrt implementation. */
+# include <sysdeps/ieee754/dbl-64/e_sqrt.c>
+
+#else
+
+/* Use VFP square root instruction. */
+# include <math.h>
+# include <sysdep.h>
+
+double
+__ieee754_sqrt (double x)
+{
+ double ret;
+# if __ARM_ARCH >= 6
+ asm ("vsqrt.f64 %P0, %P1" : "=w" (ret) : "w" (x));
+# else
+ /* As in GCC, for VFP9 Erratum 760019 avoid overwriting the
+ input. */
+ asm ("vsqrt.f64 %P0, %P1" : "=&w" (ret) : "w" (x));
+# endif
+ return ret;
+}
+strong_alias (__ieee754_sqrt, __sqrt_finite)
+
+#endif
diff --git a/sysdeps/arm/e_sqrtf.c b/sysdeps/arm/e_sqrtf.c
new file mode 100644
index 0000000..282f7c3
--- /dev/null
+++ b/sysdeps/arm/e_sqrtf.c
@@ -0,0 +1,45 @@
+/* Compute square root for float. ARM version.
+ Copyright (C) 2016 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <http://www.gnu.org/licenses/>. */
+
+#ifdef __SOFTFP__
+
+/* Use architecture-indendent sqrtf implementation. */
+# include <sysdeps/ieee754/flt-32/e_sqrtf.c>
+
+#else
+
+/* Use VFP square root instruction. */
+# include <math.h>
+# include <sysdep.h>
+
+float
+__ieee754_sqrtf (float x)
+{
+ float ret;
+# if __ARM_ARCH >= 6
+ asm ("vsqrt.f32 %0, %1" : "=t" (ret) : "t" (x));
+# else
+ /* As in GCC, for VFP9 Erratum 760019 avoid overwriting the
+ input. */
+ asm ("vsqrt.f32 %0, %1" : "=&t" (ret) : "t" (x));
+# endif
+ return ret;
+}
+strong_alias (__ieee754_sqrtf, __sqrtf_finite)
+
+#endif
-----------------------------------------------------------------------
Summary of changes:
ChangeLog | 6 +++++
sysdeps/{sparc/sparc32 => arm}/e_sqrt.c | 32 +++++++++++++++++++++---------
sysdeps/{x86_64/fpu => arm}/e_sqrtf.c | 32 ++++++++++++++++++++++--------
3 files changed, 51 insertions(+), 19 deletions(-)
copy sysdeps/{sparc/sparc32 => arm}/e_sqrt.c (59%)
copy sysdeps/{x86_64/fpu => arm}/e_sqrtf.c (59%)
hooks/post-receive
--
GNU C Library master sources