This is the mail archive of the
glibc-cvs@sourceware.org
mailing list for the glibc project.
GNU C Library master sources branch roland/nptl updated. glibc-2.19-653-g6e6909b
- From: roland at sourceware dot org
- To: glibc-cvs at sourceware dot org
- Date: 23 Jun 2014 23:23:50 -0000
- Subject: GNU C Library master sources branch roland/nptl updated. glibc-2.19-653-g6e6909b
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".
The branch, roland/nptl has been updated
via 6e6909bce48afb01ad84210b0faa83950fbb85c2 (commit)
from c1dbdf4e120fcd199441f6d89ca53c89cef99b8d (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://sourceware.org/git/gitweb.cgi?p=glibc.git;a=commitdiff;h=6e6909bce48afb01ad84210b0faa83950fbb85c2
commit 6e6909bce48afb01ad84210b0faa83950fbb85c2
Author: Roland McGrath <roland@hack.frob.com>
Date: Mon Jun 23 16:23:38 2014 -0700
Clean up NPTL fork to be compat-only.
diff --git a/ChangeLog b/ChangeLog
index 1bbb481..9c8a5f3 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,9 @@
2014-06-23 Roland McGrath <roland@hack.frob.com>
+ * nptl/pt-fork.c: Rewritten. Put everything under
+ [SHLIB_COMPAT (libpthread, GLIBC_2_0, GLIBC_2_20)].
+ Use IFUNC to redirect when possible.
+
* nptl/Makefile (routines): Add libc_pthread_init,
libc_multiple_threads, register-atfork and unregister-atfork.
(libpthread-routines): Add pthread_mutex_cond_lock and pt-fork here.
diff --git a/nptl/pt-fork.c b/nptl/pt-fork.c
index 5824094..2189358 100644
--- a/nptl/pt-fork.c
+++ b/nptl/pt-fork.c
@@ -17,11 +17,55 @@
<http://www.gnu.org/licenses/>. */
#include <unistd.h>
+#include <shlib-compat.h>
+/* libpthread once had its own fork, though there was no apparent reason
+ for it. There is no use in having a separate symbol in libpthread, but
+ the historical ABI requires it. For static linking, there is no need to
+ provide anything here--the libc version will be linked in. For shared
+ library ABI compatibility, there must be __vfork and vfork symbols in
+ libpthread.so; so we define them using IFUNC to redirect to the libc
+ function. */
-pid_t
-__fork (void)
+#if SHLIB_COMPAT (libpthread, GLIBC_2_0, GLIBC_2_20)
+
+# if HAVE_IFUNC
+
+static __typeof (fork) *
+__attribute__ ((used))
+fork_resolve (void)
+{
+ return &__libc_fork;
+}
+
+# ifdef HAVE_ASM_SET_DIRECTIVE
+# define DEFINE_FORK(name) \
+ asm (".set " #name ", fork_resolve\n" \
+ ".globl " #name "\n" \
+ ".type " #name ", %gnu_indirect_function");
+# else
+# define DEFINE_FORK(name) \
+ asm (#name " = fork_resolve\n" \
+ ".globl " #name "\n" \
+ ".type " #name ", %gnu_indirect_function");
+# endif
+
+# else /* !HAVE_IFUNC */
+
+static pid_t __attribute__ ((used))
+fork_compat (void)
{
return __libc_fork ();
}
-strong_alias (__fork, fork)
+
+# define DEFINE_FORK(name) strong_alias (fork_compat, name)
+
+# endif /* HAVE_IFUNC */
+
+DEFINE_FORK (fork_ifunc)
+compat_symbol (libpthread, fork_ifunc, fork, GLIBC_2_0);
+
+DEFINE_FORK (__fork_ifunc)
+compat_symbol (libpthread, __fork_ifunc, __fork, GLIBC_2_1_2);
+
+#endif
-----------------------------------------------------------------------
Summary of changes:
ChangeLog | 4 ++++
nptl/pt-fork.c | 50 +++++++++++++++++++++++++++++++++++++++++++++++---
2 files changed, 51 insertions(+), 3 deletions(-)
hooks/post-receive
--
GNU C Library master sources