This is the mail archive of the glibc-cvs@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

GNU C Library master sources branch master updated. glibc-2.19-257-gf6488e2b


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  f6488e2b7f13529cde762d02a0352071c078ff9a (commit)
      from  a84e78c8b3c4de94b488fdc5321f71feeb99358f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://sourceware.org/git/gitweb.cgi?p=glibc.git;a=commitdiff;h=f6488e2b7f13529cde762d02a0352071c078ff9a

commit f6488e2b7f13529cde762d02a0352071c078ff9a
Author: Will Newton <will.newton@linaro.org>
Date:   Wed Apr 2 15:23:16 2014 +0100

    elf/dl-lookup.c: Remove obsolete comment about nested function
    
    The nested function referred to has gone away so remove the
    comment. Also move the variable declaration down to where other
    variables of a similar lifetime are declared for clarity.
    
    2014-04-03  Will Newton  <will.newton@linaro.org>
    
    	* elf/dl-lookup.c (do_lookup_x): Remove comment
    	referring to nested function and move variable
    	declarations down to before first use.

diff --git a/ChangeLog b/ChangeLog
index 7e530ef..e36b689 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2014-04-03  Will Newton  <will.newton@linaro.org>
+
+	* elf/dl-lookup.c (do_lookup_x): Remove comment
+	referring to nested function and move variable
+	declarations down to before first use.
+
 2014-04-02  Joseph Myers  <joseph@codesourcery.com>
 
 	[BZ #16799]
diff --git a/elf/dl-lookup.c b/elf/dl-lookup.c
index d1b8efc..be6f76f 100644
--- a/elf/dl-lookup.c
+++ b/elf/dl-lookup.c
@@ -208,11 +208,6 @@ do_lookup_x (const char *undef_name, uint_fast32_t new_hash,
 
   do
     {
-      /* These variables are used in the nested function.  */
-      Elf_Symndx symidx;
-      int num_versions = 0;
-      const ElfW(Sym) *versioned_sym = NULL;
-
       const struct link_map *map = list[i]->l_real;
 
       /* Here come the extra test needed for `_dl_lookup_symbol_skip'.  */
@@ -237,6 +232,10 @@ do_lookup_x (const char *undef_name, uint_fast32_t new_hash,
       if (map->l_nbuckets == 0)
 	continue;
 
+      Elf_Symndx symidx;
+      int num_versions = 0;
+      const ElfW(Sym) *versioned_sym = NULL;
+
       /* The tables for this map.  */
       const ElfW(Sym) *symtab = (const void *) D_PTR (map, l_info[DT_SYMTAB]);
       const char *strtab = (const void *) D_PTR (map, l_info[DT_STRTAB]);

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog       |    6 ++++++
 elf/dl-lookup.c |    9 ++++-----
 2 files changed, 10 insertions(+), 5 deletions(-)


hooks/post-receive
-- 
GNU C Library master sources


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]