[Bug soft-fp/18473] [powerpc-nofpu] __sqrtsf2, __sqrtdf2 should be compat symbols

["cvs-commit at gcc dot gnu.org" <sourceware-bugzilla at sourceware dot org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=18473

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  0d2163ebf2fbedda09fdebe33243441d89f68b05 (commit)
      from  104502102c6fa322515ba0bb3c95c05c3185da7a (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=0d2163ebf2fbedda09fdebe33243441d89f68b05

commit 0d2163ebf2fbedda09fdebe33243441d89f68b05
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Fri Jun 1 17:25:12 2018 +0000

    Make powerpc-nofpu __sqrtsf2, __sqrtdf2 compat symbols (bug 18473).

    powerpc-nofpu libc exports __sqrtsf2 and __sqrtdf2 symbols.  The
    export of these soft-fp symbols is a mistake; they aren't part of the
    libgcc interface and GCC will never generate code that calls them.
    This patch makes them into compat symbols (no code built for static
    libc), moving their sources from the generic soft-fp sources to
    sysdeps/powerpc/nofpu (the underlying soft-fp FP_SQRT functionality
    remains of use to implement actual sqrt public interfaces, such as
    sqrtl / sqrtf128 for which it is used on various platforms, but
    __sqrt[sdt]f2 are not such interfaces).

    Tested with build-many-glibcs.py for relevant platforms.

        [BZ #18473]
        * soft-fp/sqrttf2.c: Remove file.
        * soft-fp/sqrtdf2.c: Move to ....
        * sysdeps/powerpc/nofpu/sqrtdf2.c: ... here.  Include
        <shlib-compat.h>.
        (__sqrtdf2): Make conditional on
        [SHLIB_COMPAT (libc, GLIBC_2_3_2, GLIBC_2_28)].  Define as compat
        symbol.
        * soft-fp/sqrtsf2.c: Move to ....
        * sysdeps/powerpc/nofpu/sqrtsf2.c: ... here.  Include
        <shlib-compat.h>.
        (__sqrtsf2): Make conditional on
        [SHLIB_COMPAT (libc, GLIBC_2_3_2, GLIBC_2_28)].  Define as compat
        symbol.
        * soft-fp/Makefile (gcc-single-routines): Remove sqrtsf2.
        (gcc-double-routines): Remove sqrtdf2.
        (gcc-quad-routines): Remove sqrttf2.
        * sysdeps/nios2/Makefile [$(subdir) = soft-fp] (sysdep_routines):
        Do not filter out sqrtsf2 and sqrtdf2.
        * sysdeps/powerpc/nofpu/Makefile [$(subdir) = soft-fp]
        (sysdep_routines): Add sqrtsf2 and sqrtdf2.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                                    |   24 ++++++++++++
 soft-fp/Makefile                             |    6 ++--
 soft-fp/sqrttf2.c                            |   49 --------------------------
 sysdeps/nios2/Makefile                       |    3 +-
 sysdeps/powerpc/nofpu/Makefile               |    1 +
 {soft-fp => sysdeps/powerpc/nofpu}/sqrtdf2.c |    4 ++
 {soft-fp => sysdeps/powerpc/nofpu}/sqrtsf2.c |    4 ++
 7 files changed, 37 insertions(+), 54 deletions(-)
 delete mode 100644 soft-fp/sqrttf2.c
 rename {soft-fp => sysdeps/powerpc/nofpu}/sqrtdf2.c (92%)
 rename {soft-fp => sysdeps/powerpc/nofpu}/sqrtsf2.c (92%)

-- 
You are receiving this mail because:
You are on the CC list for the bug.