[Bug libc/19463] linknamespace failures when compiled with -Os

["cvs-commit at gcc dot gnu.org" <sourceware-bugzilla at sourceware dot org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=19463

--- Comment #5 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  ec481ad81b0436460de417a8e0084935b3763ebb (commit)
      from  7d15ef84f50a80cb170f8ce3457010f59e221cb8 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=ec481ad81b0436460de417a8e0084935b3763ebb

commit ec481ad81b0436460de417a8e0084935b3763ebb
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Mon Feb 19 17:32:34 2018 +0000

    Fix -Os ferror_unlocked linknamespace, localplt issues (bug 15105, bug
19463).

    Continuing the fixes for linknamespace and localplt test failures with
    -Os that arise from functions not being inlined in that case, this
    patch fixes such failures for ferror_unlocked.

    The usual approach is followed of adding __ferror_unlocked (inlined
    when ferror_unlocked is), making calls use it when required for
    namespace reasons (only one such call), and using libc_hidden_proto /
    libc_hidden_weak for the ferror_unlocked weak alias when only localplt
    but not namespace issues are involved.

    Tested for x86_64 (both without -Os to make sure that case continues
    to work, and with -Os to make sure all the relevant linknamespace and
    localplt test failures are resolved).  Because of other such failures
    that remain after this patch, neither of the bugs can yet be closed.

        [BZ #15105]
        [BZ #19463]
        * libio/ferror_u.c (ferror_unlocked): Rename to __ferror_unlocked
        and define as weak alias of __ferror_unlocked.  Use
        libc_hidden_weak.
        * include/stdio.h [!_ISOMAC] (ferror_unlocked): Use
        libc_hidden_proto.
        [!_ISOMAC] (__ferror_unlocked) New declaration, and inline
        function if [__USE_EXTERN_INLINES].
        * time/getdate.c (__getdate_r): Call __ferror_unlocked instead of
        ferror_unlocked.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog        |   14 ++++++++++++++
 include/stdio.h  |    8 ++++++++
 libio/ferror_u.c |    4 +++-
 time/getdate.c   |    2 +-
 4 files changed, 26 insertions(+), 2 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.