This is the mail archive of the glibc-bugs@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug localedata/22848] ca_ES: update date definitions from CLDR


https://sourceware.org/bugzilla/show_bug.cgi?id=22848

Egmont Koblinger <egmont at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |egmont at gmail dot com

--- Comment #8 from Egmont Koblinger <egmont at gmail dot com> ---
(In reply to Robert Buj from comment #6)

> [robert@fedora temp]$ ls -ltr --time-style="+%e %_11B %H:%M"
                                                   ^^^

printf-style width and precision always counts bytes rather than characters,
let alone display width. So if you need aligned output in non-English context,
you should refrain from using them.

Aligning long month names doesn't even work with English names:

$ LC_ALL=en_US.UTF-8 /tmp/coreutils-8.29/src/ls -ltr --time-style='+%B'
-rw-r--r-- 1 egmont egmont 0 January file01
-rw-r--r-- 1 egmont egmont 0 February file02
-rw-r--r-- 1 egmont egmont 0 March file03
[...]

Checking in another language (with varying length and various accents for
short/long month names) the output is automatically properly aligned with short
month names, but not with long ones:

$ LC_ALL=hu_HU.UTF-8 /tmp/coreutils-8.29/src/ls -ltr --time-style='+%b'
-rw-r--r-- 1 egmont egmont 0 jan   file01
-rw-r--r-- 1 egmont egmont 0 febr  file02
-rw-r--r-- 1 egmont egmont 0 márc  file03
-rw-r--r-- 1 egmont egmont 0 ápr   file04
[...]
-rw-r--r-- 1 egmont egmont 0 aug   file08
-rw-r--r-- 1 egmont egmont 0 szept file09
[...]

$ LC_ALL=hu_HU.UTF-8 /tmp/coreutils-8.29/src/ls -ltr --time-style='+%B'
-rw-r--r-- 1 egmont egmont 0 január file01
-rw-r--r-- 1 egmont egmont 0 február file02
-rw-r--r-- 1 egmont egmont 0 március file03
-rw-r--r-- 1 egmont egmont 0 április file04
-rw-r--r-- 1 egmont egmont 0 május file05
[...]

Since strftime() obviously cannot have any clue about the other dates you have
called this method with, and are about to call this method with; the nice
alignment of abbreviated month names must be done by ls. In coreutils/src/ls.c,
you find the relevant code in line 1100-ish (v8.29), around abmon_init().

I think it should be brought up on the coreutils mailing list to do the same
with the full month names too (and BTW for both the genitive and nominative
variants).

The correctness of your proposed patch (which I cannot comment on) shouldn't
depend on this, and your patch shouldn't be blocked by ls's limited aligning
capabilities.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]