[Bug libc/14553] Namespace pollution loff_t in sys/types.h

["cvs-commit at gcc dot gnu.org" <sourceware-bugzilla at sourceware dot org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=14553

--- Comment #2 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  663e7d784977f6b15c0cab73f754f9f39c9c0c2c (commit)
      from  6d7aa2b531088c3a277911534179975eb2622954 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=663e7d784977f6b15c0cab73f754f9f39c9c0c2c

commit 663e7d784977f6b15c0cab73f754f9f39c9c0c2c
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Tue Feb 6 21:29:50 2018 +0000

    Only define loff_t for __USE_MISC (bug 14553).

    Bug 14553 reports that sys/types.h defines loff_t unconditionally,
    despite it not being part of any supported standard.  This is
    permitted by the POSIX *_t reservation, but as a
    quality-of-implementation issue it's still best not to define it
    except for __USE_MISC.  This patch conditions the definition
    accordingly, updating a macro in sysdeps/unix/sysv/linux/sys/quota.h
    to use __loff_t so it still works even if __USE_MISC is not defined.

    codesearch.debian.net suggests there are quite a lot of loff_t uses
    outside glibc, but it might well make sense to change all (few) uses
    of loff_t or __loff_t inside glibc to use off64_t or __off64_t
    instead, leaving only the definitions, treating this name as
    obsolescent.

    Tested for x86_64.

        [BZ #14553]
        * posix/sys/types.h (loff_t): Only define for [__USE_MISC].
        * sysdeps/unix/sysv/linux/sys/quota.h (dqoff): Use __loff_t
        instead of loff_t.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                           |    7 +++++++
 posix/sys/types.h                   |    3 +--
 sysdeps/unix/sysv/linux/sys/quota.h |    2 +-
 3 files changed, 9 insertions(+), 3 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.