This is the mail archive of the glibc-bugs@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug dynamic-link/22093] ld.so no longer searches in .../x86_64


https://sourceware.org/bugzilla/show_bug.cgi?id=22093

--- Comment #7 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, release/2.26/master has been updated
       via  b2c78ae69eb5845c94db94e87a2addd695f978c0 (commit)
      from  6182b3708b7af316454c81467538a8c20c1b046d (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=b2c78ae69eb5845c94db94e87a2addd695f978c0

commit b2c78ae69eb5845c94db94e87a2addd695f978c0
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Sun Oct 22 04:14:54 2017 -0700

    x86: Add x86_64 to x86-64 HWCAP [BZ #22093]

    Before glibc 2.26, ld.so set dl_platform to "x86_64" and searched the
    "x86_64" subdirectory when loading a shared library.  ld.so in glibc
    2.26 was changed to set dl_platform to "haswell" or "xeon_phi", based
    on supported ISAs.  This led to shared library loading failure for
    shared libraries placed under the "x86_64" subdirectory.

    This patch adds "x86_64" to x86-64 dl_hwcap so that ld.so will always
    search the "x86_64" subdirectory when loading a shared library.

    NB: We can't set x86-64 dl_platform to "x86-64" since ld.so will skip
    the "haswell" and "xeon_phi" subdirectories on "haswell" and "xeon_phi"
    machines.

    Tested on i686 and x86-64.

        [BZ #22093]
        * sysdeps/x86/cpu-features.c (init_cpu_features): Initialize
        GLRO(dl_hwcap) to HWCAP_X86_64 for x86-64.
        * sysdeps/x86/dl-hwcap.h (HWCAP_COUNT): Updated.
        (HWCAP_IMPORTANT): Likewise.
        (HWCAP_X86_64): New enum.
        (HWCAP_X86_AVX512_1): Updated.
        * sysdeps/x86/dl-procinfo.c (_dl_x86_hwcap_flags): Add "x86_64".
        * sysdeps/x86_64/Makefile (tests): Add tst-x86_64-1.
        (modules-names): Add x86_64/tst-x86_64mod-1.
        (LDFLAGS-tst-x86_64mod-1.so): New.
        ($(objpfx)tst-x86_64-1): Likewise.
        ($(objpfx)x86_64/tst-x86_64mod-1.os): Likewise.
        (tst-x86_64-1-clean): Likewise.
        * sysdeps/x86_64/tst-x86_64-1.c: New file.
        * sysdeps/x86_64/tst-x86_64mod-1.c: Likewise.

    (cherry picked from commit 45ff34638f034877b6a490c217d6a0632ce263f4)

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                                          |   19 +++++++++++++++++++
 NEWS                                               |    1 +
 sysdeps/x86/cpu-features.c                         |    3 ++-
 sysdeps/x86/dl-hwcap.h                             |   12 +++++++-----
 sysdeps/x86/dl-procinfo.c                          |    4 ++--
 sysdeps/x86_64/Makefile                            |   17 +++++++++++++++++
 sysdeps/x86_64/{tst-quad1.c => tst-x86_64-1.c}     |    3 ++-
 .../strcmp-sse4_2.S => tst-x86_64mod-1.c}          |    9 +++++----
 8 files changed, 55 insertions(+), 13 deletions(-)
 copy sysdeps/x86_64/{tst-quad1.c => tst-x86_64-1.c} (87%)
 copy sysdeps/x86_64/{multiarch/strcmp-sse4_2.S => tst-x86_64mod-1.c} (90%)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]