This is the mail archive of the glibc-bugs@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug libc/21780] hppa: p{read,write}v2 does not set ENOSUP on invalid flag


https://sourceware.org/bugzilla/show_bug.cgi?id=21780

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  852d63120783fae5bf85a067320dc4ba1ed59f11 (commit)
      from  cd65836b5fba2d34a4c04c15b47723ab9237b66a (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=852d63120783fae5bf85a067320dc4ba1ed59f11

commit 852d63120783fae5bf85a067320dc4ba1ed59f11
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date:   Mon Jul 17 10:59:59 2017 -0300

    posix: Set p{read,write}v2 to return ENOTSUP (BZ#21780)

    Different than other architectures hppa-linux-gnu define different values
    for ENOTSUP and EOPNOTSUPP, where the later is a Linux specific one.
    This leads to tst-preadwritev{64}v2 tests failures:

    $ ./testrun.sh misc/tst-preadvwritev2
    error: tst-preadvwritev2-common.c:35: preadv2 failure did not set errno to
ENOTSUP (223)
    error: 1 test failures

    The straightforward fix is to return the POSIX defined ENOTSUP on all
    p{read,write}v{64}v2 implementations instead of Linux specific one.

    Checked on x86_64-linux-gnu and the tst-preadwritev{64}v2 on
    hppa-linux-gnu (although due the installed kernel on my testing system
    the pwritev{64}v2 with an invalid flag still fails due a known kernel
    issue [1]).

        [BZ #21780]
        * sysdeps/posix/preadv2.c (preadv2): Use ENOTSUP instead of
        EOPNOTSUPP.
        * sysdeps/posix/preadv64v2.c (preadv64v2): Likewise.
        * sysdeps/posix/pwritev2.c (pwritev2): Likewise.
        * sysdeps/posix/pwritev64v2.c (pwritev64v2): Likewise.
        * sysdeps/unix/sysv/linux/preadv2.c (preadv2): Likewise.
        * sysdeps/unix/sysv/linux/preadv64v2.c (preadv64v2): Likewise.
        * sysdeps/unix/sysv/linux/pwritev2.c (pwritev2): Likewise.
        * sysdeps/unix/sysv/linux/pwritev64v2.c (pwritev64v2): Likewise.

    [1] https://sourceware.org/ml/libc-alpha/2017-06/msg00726.html

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                             |   13 +++++++++++++
 sysdeps/posix/preadv2.c               |    2 +-
 sysdeps/posix/preadv64v2.c            |    2 +-
 sysdeps/posix/pwritev2.c              |    2 +-
 sysdeps/posix/pwritev64v2.c           |    2 +-
 sysdeps/unix/sysv/linux/preadv2.c     |    4 ++--
 sysdeps/unix/sysv/linux/preadv64v2.c  |    4 ++--
 sysdeps/unix/sysv/linux/pwritev2.c    |    4 ++--
 sysdeps/unix/sysv/linux/pwritev64v2.c |    4 ++--
 9 files changed, 25 insertions(+), 12 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]