This is the mail archive of the glibc-bugs@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug libc/21666] .symver is used on common symbol


https://sourceware.org/bugzilla/show_bug.cgi?id=21666

--- Comment #12 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, release/2.24/master has been updated
       via  fd5fade3054e4e5356154ea24e65d7ed816f5a1d (commit)
      from  cc392d6339e4172aa0cb5bdb2f006b4db5d7b831 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=fd5fade3054e4e5356154ea24e65d7ed816f5a1d

commit fd5fade3054e4e5356154ea24e65d7ed816f5a1d
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Wed Jul 26 10:08:46 2017 -0700

    Avoid .symver on common symbols [BZ #21666]

    The .symver directive on common symbol just creates a new common symbol,
    not an alias and the newer assembler with the bug fix for

    https://sourceware.org/bugzilla/show_bug.cgi?id=21661

    will issue an error.  Before the fix, we got

    $ readelf -sW libc.so | grep "loc[12s]"
      5109: 00000000003a0608     8 OBJECT  LOCAL  DEFAULT   36 loc1
      5188: 00000000003a0610     8 OBJECT  LOCAL  DEFAULT   36 loc2
      5455: 00000000003a0618     8 OBJECT  LOCAL  DEFAULT   36 locs
      6575: 00000000003a05f0     8 OBJECT  GLOBAL DEFAULT   36 locs@GLIBC_2.2.5
      7156: 00000000003a05f8     8 OBJECT  GLOBAL DEFAULT   36 loc1@GLIBC_2.2.5
      7312: 00000000003a0600     8 OBJECT  GLOBAL DEFAULT   36 loc2@GLIBC_2.2.5

    in libc.so.  The versioned loc1, loc2 and locs have the wrong addresses.
    After the fix, we got

    $ readelf -sW libc.so | grep "loc[12s]"
      6570: 000000000039e3b8     8 OBJECT  GLOBAL DEFAULT   34 locs@GLIBC_2.2.5
      7151: 000000000039e3c8     8 OBJECT  GLOBAL DEFAULT   34 loc1@GLIBC_2.2.5
      7307: 000000000039e3c0     8 OBJECT  GLOBAL DEFAULT   34 loc2@GLIBC_2.2.5

        [BZ #21666]
        * misc/regexp.c (loc1): Add __attribute__ ((nocommon));
        (loc2): Likewise.
        (locs): Likewise.

    (cherry picked from commit 388b4f1a02f3a801965028bbfcd48d905638b797)

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog     |    7 +++++++
 misc/regexp.c |    9 +++++----
 2 files changed, 12 insertions(+), 4 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]