[Bug libc/21243] support_delete_temp_file should issue warning for failed remove()

["fweimer at redhat dot com" <sourceware-bugzilla at sourceware dot org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=21243

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fweimer at redhat dot com
              Flags|                            |security-

--- Comment #1 from Florian Weimer <fweimer at redhat dot com> ---
(In reply to Carlos O'Donell from comment #0)
> In support/temp_file.c(support_delete_temp_files):
> 
>  98 support_delete_temp_files (void)
>  99 {
> 100   while (temp_name_list != NULL)
> 101     {
> 102       remove (temp_name_list->name);
> 103       free (temp_name_list->name);
> 104 
> 105       struct temp_name_list *next
> 106         = (struct temp_name_list *) temp_name_list->q.q_forw;
> 107       free (temp_name_list);
> 108       temp_name_list = next;
> 109     }
> 110 }
> 111 
> 
> We don't check the results of remove() and it could have failed. We should
> check the result and issue a warning or fail depending on the situation.

I think this happens if the atexit handler runs in the child and in the parent.
 I don't think we should warn for that.

-- 
You are receiving this mail because:
You are on the CC list for the bug.