This is the mail archive of the glibc-bugs@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug manual/20524] strverscmp is inconsistent


https://sourceware.org/bugzilla/show_bug.cgi?id=20524

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://sourceware.org/bugz
                   |                            |illa/show_bug.cgi?id=9913

--- Comment #6 from Florian Weimer <fweimer at redhat dot com> ---
(In reply to Peter Rosin from comment #5)
> Created attachment 9481 [details]
> fix ordering in strverscmp
> 
> Ok, it was said that fixing it was not an option "at this point" since "it
> is what it is". But the function has been "fixed" once, in 2009 [1], so
> what is different "at this point"?

> [1]
> https://sourceware.org/git/?p=glibc.git;a=commitdiff;
> h=4546646233574f321f9deedff928b980d82f4fc7

This was due to bug 9913, which broke transitivity of the comparison, a real
bug which could lead to crashes during sorting and so on.  There was little
choice in fixing this.

My testing so far is that the current implementation has the proper properties
of a comparison function.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]