This is the mail archive of the glibc-bugs@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug string/19776] Unreachable code in sysdeps/x86_64/multiarch/memcpy-sse2-unaligned.S


https://sourceware.org/bugzilla/show_bug.cgi?id=19776

--- Comment #3 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, hjl/pr19776/master has been created
        at  8db09f10f2ad8cfd6d6fc158b336deba82132764 (commit)

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=8db09f10f2ad8cfd6d6fc158b336deba82132764

commit 8db09f10f2ad8cfd6d6fc158b336deba82132764
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Mon Mar 7 05:47:26 2016 -0800

    Use __memcpy_chk_sse2_unaligned

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=af7cf21daf0b7c6492c0441c546f9290d3e03f9a

commit af7cf21daf0b7c6492c0441c546f9290d3e03f9a
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Mon Mar 7 05:44:58 2016 -0800

    Use __mempcpy_chk_sse2_unaligned

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=bc2ec4cb418341a97056a3fd503b00c449c59d6e

commit bc2ec4cb418341a97056a3fd503b00c449c59d6e
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Mon Mar 7 05:42:46 2016 -0800

    Use __mempcpy_sse2_unaligned

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=9452ba101b95ec3a20074b1cc8fd2d84b6e0e859

commit 9452ba101b95ec3a20074b1cc8fd2d84b6e0e859
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Sun Mar 6 17:06:41 2016 -0800

    Add __mempcpy_sse2_unaligned and _chk functions

    Add __mempcpy_chk_sse2_unaligned, __mempcpy_sse2_unaligned and
    __memcpy_chk_sse2_unaligned.

        * sysdeps/x86_64/multiarch/ifunc-impl-list.c
        (__libc_ifunc_impl_list): Test __memcpy_chk_sse2_unaligned,
        __mempcpy_chk_sse2_unaligned and __mempcpy_sse2_unaligned.
        * sysdeps/x86_64/multiarch/memcpy-sse2-unaligned.S
        (__mempcpy_chk_sse2_unaligned): New.
        (__mempcpy_sse2_unaligned): Likewise.
        (__memcpy_chk_sse2_unaligned): Likewise.
        (L(start): New label.

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=b812ca4864339d011edde57a86b27b80748bbfda

commit b812ca4864339d011edde57a86b27b80748bbfda
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Sun Mar 6 16:52:53 2016 -0800

    Remove L(overlapping) from memcpy-sse2-unaligned.S

    Since memcpy doesn't need to check overlapping source and destination,
    we can remove L(overlapping).

        [BZ #19776]
        * sysdeps/x86_64/multiarch/memcpy-sse2-unaligned.S
        (L(overlapping)): Removed.

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=b74a495c76c05e9685482322a6a30d12a98a8a44

commit b74a495c76c05e9685482322a6a30d12a98a8a44
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Sun Mar 6 13:46:54 2016 -0800

    Don't use RAX as scratch register

    To prepare sharing code with mempcpy, don't use RAX as scratch register
    so that RAX can be set to the return value at entrance.

        [BZ #19776]
        * sysdeps/x86_64/multiarch/memcpy-sse2-unaligned.S: Don't use
        RAX as scratch register.

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=ab3ae148820f5023254a4979d6eef60537f0bb03

commit ab3ae148820f5023254a4979d6eef60537f0bb03
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Sun Mar 6 14:16:32 2016 -0800

    Remove dead code from memcpy-sse2-unaligned.S

    There are

    ENTRY(__memcpy_sse2_unaligned)
       movq  %rsi, %rax
       leaq  (%rdx,%rdx), %rcx
       subq  %rdi, %rax
       subq  %rdx, %rax
       cmpq  %rcx, %rax
       jb L(overlapping)

    When branch is taken,

       cmpq  %rsi, %rdi
       jae   .L3

    will never be taken.  We can remove the dead code.

        [BZ #19776]
        * sysdeps/x86_64/multiarch/memcpy-sse2-unaligned.S (.L3) Removed.

-----------------------------------------------------------------------

-- 
You are receiving this mail because:
You are on the CC list for the bug.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]