[Bug ports/19452] New: m68k: Unmatched parentheses in __bswap64() - byteswap.h

["jerome at ecere dot com" <sourceware-bugzilla at sourceware dot org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=19452

            Bug ID: 19452
           Summary: m68k: Unmatched parentheses in __bswap64() -
                    byteswap.h
           Product: glibc
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: ports
          Assignee: unassigned at sourceware dot org
          Reporter: jerome at ecere dot com
                CC: carlos at redhat dot com, roland at gnu dot org
  Target Milestone: ---

There is one more '(' than ')' in __bswap64(), sysdeps/m68k/bits/byteswap.h.
This is causing our ecere-sdk build (and probably lots of other stuff since
we're not even including byteswap.h directly) to fail on m68k:

https://buildd.debian.org/status/fetch.php?pkg=ecere-sdk&arch=m68k&ver=0.44.13-1&stamp=1451685605

  77 __extension__
  78 static __always_inline unsigned long long
  79 __bswap_64 (unsigned long long __bsx)
  80 {
  81   if (__builtin_constant_p (__bsx))
  82     return __bswap_constant_64 (__bsx);
  83   return (__bswap_32 (__bsx >> 32)
  84           | ((unsigned long long) __bswap_32 (__bsx) << 32));
  85 }

Probably want:

  82     return __bswap_constant_64 (__bsx);
- 83   return (__bswap_32 (__bsx >> 32)
+ 83   return __bswap_32 (__bsx >> 32)
  84           | ((unsigned long long) __bswap_32 (__bsx) << 32));


https://sourceware.org/git/?p=glibc.git;a=blob;f=sysdeps/m68k/bits/byteswap.h;h=a8deeaa514fe679bda1ddf5a206da6ff713420ad;hb=4e42b5b8f89f0e288e68be7ad70f9525aebc2cff#l84

-- 
You are receiving this mail because:
You are on the CC list for the bug.