This is the mail archive of the glibc-bugs@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug libc/19212] features.h not -Wundef clean


https://sourceware.org/bugzilla/show_bug.cgi?id=19212

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  f248238cf43bd751db29e6f151d6da7645337ff5 (commit)
      from  8fed86556b7e162d2926f0ba6a573ed193ff882f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=f248238cf43bd751db29e6f151d6da7645337ff5

commit f248238cf43bd751db29e6f151d6da7645337ff5
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Thu Nov 5 21:19:37 2015 +0000

    Fix features.h for -Wundef (bug 19212).

    features.h is not clean with -Wundef (for the installed header, of
    course this only appears with -Wsystem-headers).  In ISO C standards
    modes, you get a series of warnings / errors relating to
    _POSIX_C_SOURCE and _XOPEN_SOURCE not being defined when tested in
    standards mode and uses #undef _GNU_SOURCE to avoid the default
    _GNU_SOURCE from libc-symbols.h.  This patch changes the relevant #if
    conditionals to avoid these warnings / errors.

    Tested for x86_64 and x86 (testsuite, and that installed shared
    libraries are unchanged by the patch).

        [BZ #19212]
        * include/features.h [(_XOPEN_SOURCE - 0) >= 500]: Change
        conditional to [defined _XOPEN_SOURCE && (_XOPEN_SOURCE - 0) >=
        500].
        [_POSIX_C_SOURCE >= 1]: Change conditional to [defined
        _POSIX_C_SOURCE && _POSIX_C_SOURCE >= 1].
        [(_POSIX_C_SOURCE - 0) >= 199309L]: Change conditional to [defined
        _POSIX_C_SOURCE && (_POSIX_C_SOURCE - 0) >= 199309L].
        [(_POSIX_C_SOURCE - 0) >= 199506L]: Change conditional to [defined
        _POSIX_C_SOURCE && (_POSIX_C_SOURCE - 0) >= 199506L].
        [(_POSIX_C_SOURCE - 0) >= 200112L]: Change conditional to [defined
        _POSIX_C_SOURCE && (_POSIX_C_SOURCE - 0) >= 200112L].
        [(_POSIX_C_SOURCE - 0) >= 200809L]: Change conditional to [defined
        _POSIX_C_SOURCE && (_POSIX_C_SOURCE - 0) >= 200809L].

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog          |   15 +++++++++++++++
 NEWS               |    2 +-
 include/features.h |   17 ++++++++++-------
 3 files changed, 26 insertions(+), 8 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]