This is the mail archive of the
glibc-bugs@sourceware.org
mailing list for the glibc project.
[Bug libc/18540] getpass fflush_unlocked namespace
- From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla at sourceware dot org>
- To: glibc-bugs at sourceware dot org
- Date: Wed, 17 Jun 2015 20:15:11 +0000
- Subject: [Bug libc/18540] getpass fflush_unlocked namespace
- Auto-submitted: auto-generated
- References: <bug-18540-131 at http dot sourceware dot org/bugzilla/>
https://sourceware.org/bugzilla/show_bug.cgi?id=18540
--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".
The branch, master has been updated
via eb1fae6a450b3cce5a75c1ed1a734520c56a6457 (commit)
from 68f1ba4ba4b9cb4661ca3ed446d0967ca79c2a47 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=eb1fae6a450b3cce5a75c1ed1a734520c56a6457
commit eb1fae6a450b3cce5a75c1ed1a734520c56a6457
Author: Joseph Myers <joseph@codesourcery.com>
Date: Wed Jun 17 20:14:18 2015 +0000
Fix getpass fflush_unlocked namespace (bug 18540).
The getpass function (XPG3 / XPG4 / UNIX98) calls fflush_unlocked (not
in any of those standards). This patch fixes this by making
fflush_unlocked into a weak alias for __fflush_unlocked and calling
__fflush_unlocked from getpass.
Tested for x86_64 and x86 (testsuite, and that disassembly of
installed stripped shared libraries is unchanged by the patch).
[BZ #18540]
* libio/iofflush.c [!_IO_MTSAFE_IO] (__fflush_unlocked): Define as
strong alias of _IO_fflush. Use libc_hidden_def.
* libio/iofflush_u.c (fflush_unlocked): Rename to
__fflush_unlocked and define as weak alias of __fflush_unlocked.
Use libc_hidden_weak.
* include/stdio.h (__fflush_unlocked): Declare. Use
libc_hidden_proto.
* misc/getpass.c (getpass): Call __fflush_unlocked instead of
fflush_unlocked.
* conform/Makefile (test-xfail-UNIX98/unistd.h/linknamespace):
Remove variable.
-----------------------------------------------------------------------
Summary of changes:
ChangeLog | 13 +++++++++++++
NEWS | 2 +-
conform/Makefile | 1 -
include/stdio.h | 2 ++
libio/iofflush.c | 2 ++
libio/iofflush_u.c | 6 ++++--
misc/getpass.c | 2 +-
7 files changed, 23 insertions(+), 5 deletions(-)
--
You are receiving this mail because:
You are on the CC list for the bug.