This is the mail archive of the glibc-bugs@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug libc/18498] open_memstream namespace


https://sourceware.org/bugzilla/show_bug.cgi?id=18498

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  711f67a789ba3505ae7b071453763e06590aa245 (commit)
      from  a5f0adb39b3a029b3fcd1b0d879eb45d9bd742cd (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=711f67a789ba3505ae7b071453763e06590aa245

commit 711f67a789ba3505ae7b071453763e06590aa245
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Fri Jun 5 23:32:46 2015 +0000

    Fix open_memstream namespace (bug 18498).

    open_memstream is new in the 2008 edition of POSIX.  However, the
    older functions getopt, closelog and fmtmsg all bring in references to
    it.  This patch fixes this in the usual way, making open_memstream
    into a weak alias of __open_memstream and calling __open_memstream
    from the relevant places.

    Tested for x86_64 and x86 (testsuite, and that disassembly of
    installed shared libraries is unchanged by the patch).  32-bit builds
    produce an XPASS for conform/POSIX/unistd.h/linknamespace after this
    patch (because the only cause of failure left there now is 64-bit
    specific); that will disappear once the 64-bit failure is resolved and
    the XFAIL removed at that time.

        [BZ #18498]
        * libio/memstream.c (open_memstream): Rename to __open_memstream
        and define as weak alias of __open_memstream.
        * include/stdio.h (__open_memstream): Declare.  Use
        libc_hidden_proto.
        (open_memstream): Don't use libc_hidden_proto.
        * misc/syslog.c (__vsyslog_chk): Call __open_memstream instead of
        open_memstream.
        * posix/getopt.c (_getopt_internal_r): Likewise.
        * conform/Makefile (test-xfail-XPG3/stdio.h/linknamespace): Remove
        variable.
        (test-xfail-XPG4/stdio.h/linknamespace): Likewise.
        (test-xfail-UNIX98/stdio.h/linknamespace): Likewise.
        (test-xfail-XOPEN2K/unistd.h/linknamespace): Likewise.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog         |   15 +++++++++++++++
 NEWS              |    2 +-
 conform/Makefile  |    4 ----
 include/stdio.h   |    5 ++++-
 libio/memstream.c |    5 +++--
 misc/syslog.c     |    2 +-
 posix/getopt.c    |    2 +-
 7 files changed, 25 insertions(+), 10 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]