[Bug libc/18469] fnmatch towlower namespace

["cvs-commit at gcc dot gnu.org" <sourceware-bugzilla at sourceware dot org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=18469

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  bb4acb522c9206b8476a88be44606bf1bc1e96f6 (commit)
      from  6cfae52edfb487ca3b78336a061acb6694338f72 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=bb4acb522c9206b8476a88be44606bf1bc1e96f6

commit bb4acb522c9206b8476a88be44606bf1bc1e96f6
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Tue Jun 2 20:23:09 2015 +0000

    Fix fnmatch towlower namespace (bug 18469).

    fnmatch brings in references to towlower (and thereby towupper), which
    isn't in all the standards that contain fnmatch, resulting in
    linknamespace test failures.  (This is contrary to glibc conventions,
    rather than a standards conformance issue, because of the to*
    reservation.)  This patch fixes this in the usual way, making those
    functions into weak aliases.

    Tested for x86_64 and x86 (testsuite, and that disassembly of
    installed shared libraries is unchanged by the patch).  This is on top
    of <https://sourceware.org/ml/libc-alpha/2015-06/msg00019.html>, but
    the two patches should be independent.

    (The __attribute_pure__ on the declarations in include/wctype.h comes
    from GCC's built-in attributes for towlower and towupper, and is
    needed to get the same code generation for fnmatch before and after
    the patch.  It seems likely there are cases where the declaration of
    __foo in the internal headers is missing attributes from foo in the
    public headers, built-in to GCC or both, but I don't know a good way
    to detect such missing attributes.)

        [BZ #18469]
        * wctype/wcfuncs.c (towlower): Rename to __towlower and define as
        weak alias of __towlower.  Use libc_hidden_weak.
        (towupper): Rename to __towupper and define as weak alias of
        __towupper.  Use libc_hidden_weak.
        * include/wctype.h (__towlower): Declare.  Use libc_hidden_proto.
        (__towupper): Likewise.
        * posix/fnmatch.c [HANDLE_MULTIBYTE && _LIBC] (FOLD): Use
        __towlower instead of towlower.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog        |   12 ++++++++++++
 NEWS             |    2 +-
 include/wctype.h |    4 ++++
 posix/fnmatch.c  |    2 +-
 wctype/wcfuncs.c |   12 ++++++++----
 5 files changed, 26 insertions(+), 6 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.