[Bug libc/17635] isblank / isascii / toascii namespace

["cvs-commit at gcc dot gnu.org" <sourceware-bugzilla at sourceware dot org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=17635

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  b8986484e47d6c9b3aecbd259dac52b4c9c99e0d (commit)
      from  a287953a45b0759ce08349a299a458c89b7d8276 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=b8986484e47d6c9b3aecbd259dac52b4c9c99e0d

commit b8986484e47d6c9b3aecbd259dac52b4c9c99e0d
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Mon Jan 5 15:06:57 2015 +0000

    Fix isblank / isascii / toascii namespace (bug 17635).

    Use of isblank brings in isascii and toascii, but isblank is a C99
    function and the other two aren't; similarly, isascii and toascii are
    UNIX98 functions and bring in isblank, which isn't.  (Not a
    conformance issue because of the is* and to* reservation, but still
    contrary to glibc practice.)  This patch fixes this by splitting
    isblank out of ctype-extn.c to a separate ctype-c99.c.  isblank_l is
    also moved to a separate file, ctype-c99_l.c (non-XSI POSIX.1-2008 has
    isblank_l, but isascii / toascii are marked OB XSI).  (In principle
    all these functions could go in separate files - that's optimal for
    static linking - but they are also all very small, and splitting them
    all out is not needed to fix the present bug.)

    Tested for x86_64 (testsuite, and that installed stripped shared
    libraries are unchanged by the patch - the ordering in which new and
    existing sources are listed in ctype/Makefile is arranged so functions
    go in the same order so that this comparison works).

        [BZ #17635]
        * ctype/ctype-c99.c: New file.  isblank implementation moved from
        ...
        * ctype/ctype-extn.c: ... here.
        (__isblank_l): Move to ...
        * ctype/ctype-c99_l.c: ... here.  New file.
        * ctype/Makefile (routines): Add ctype-c99 and ctype-c99_l.
        * conform/Makefile (test-xfail-ISO99/ctype.h/linknamespace):
        Remove variable.
        (test-xfail-ISO11/ctype.h/linknamespace): Likewise.
        (test-xfail-XPG3/ctype.h/linknamespace): Likewise.
        (test-xfail-XPG4/ctype.h/linknamespace): Likewise.
        (test-xfail-UNIX98/ctype.h/linknamespace): Likewise.
        (test-xfail-POSIX2008/ctype.h/linknamespace): Likewise.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                             |   15 +++++++++++++++
 NEWS                                  |    6 +++---
 conform/Makefile                      |    6 ------
 ctype/Makefile                        |    2 +-
 stdlib/llabs.c => ctype/ctype-c99.c   |   16 ++++++----------
 stdlib/llabs.c => ctype/ctype-c99_l.c |   17 +++++++----------
 ctype/ctype-extn.c                    |   17 +----------------
 7 files changed, 33 insertions(+), 46 deletions(-)
 copy stdlib/llabs.c => ctype/ctype-c99.c (81%)
 copy stdlib/llabs.c => ctype/ctype-c99_l.c (80%)

-- 
You are receiving this mail because:
You are on the CC list for the bug.