[Bug libc/13176] cppcheck warnings

["ppluzhnikov at google dot com" <sourceware-bugzilla at sourceware dot org>]

http://sourceware.org/bugzilla/show_bug.cgi?id=13176

Paul Pluzhnikov <ppluzhnikov at google dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ppluzhnikov at google dot
                   |                            |com

--- Comment #2 from Paul Pluzhnikov <ppluzhnikov at google dot com> 2011-09-11 18:17:34 UTC ---
I took a look at a random sample of non-test issues in the report:

---
file="elf/pldd.c" line="198" id="resourceLeak" severity="error" msg="Resource
leak: taskfd"

False positive: cppckeck doesn't understand that fdopendir() transfers
ownership of taskfd to the DIR that is opened.

---
file="nscd/nscd_helper.c" line="186" id="uninitvar" severity="error"
msg="Uninitialized variable: sock"

False positive: cppcheck doesn't understand relationship between SOCK_CLOEXEC
and __ASSUME_SOCK_CLOEXEC.

---
file="posix/regcomp.c" line="2758" id="uninitvar" severity="error"
msg="Uninitialized variable: symb_table"

Probably false positive (but tough to really tell): cppcheck doesn't appear to
understand nested functions.

---
file="stdlib/isomac.c" line="267" id="memleak" severity="error" msg="Memory
leak: command"

True positive, but not very interesting (helper program).

---
file="sysdeps/unix/readdir_r.c" line="113" id="nullPointer" severity="error"
msg="Possible null pointer dereference: dp - otherwise it is redundant to check
if dp is null at line 115"

False positive: cppcheck doesn't understand control flow.

---
file="sysdeps/unix/sysv/linux/opensock.c" line="92" id="uninitvar"
severity="error" msg="Uninitialized variable: result"

False positive (same as nscd/nscd_helper.c).


Bottom line: cppcheck could stand some improvement ;-)

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.