This is the mail archive of the
glibc-bugs@sourceware.org
mailing list for the glibc project.
[Bug hurd/12187] New: [PATCH] sysdeps/mach/hurd: critical error values get overwritten
- From: "nikai at nikai dot net" <sourceware-bugzilla at sourceware dot org>
- To: glibc-bugs at sources dot redhat dot com
- Date: Wed, 3 Nov 2010 16:22:04 +0000
- Subject: [Bug hurd/12187] New: [PATCH] sysdeps/mach/hurd: critical error values get overwritten
- Auto-submitted: auto-generated
http://sourceware.org/bugzilla/show_bug.cgi?id=12187
Summary: [PATCH] sysdeps/mach/hurd: critical error values get
overwritten
Product: glibc
Version: 2.13
Status: NEW
Severity: normal
Priority: P2
Component: hurd
AssignedTo: roland@gnu.org
ReportedBy: nikai@nikai.net
Hi there!
I noticed three places where critical error values get
overwritten. It looks to me as if the intention might
instead have been to return the EIEIO value when the
'computer bought the farm'.
Best regards,
Nicolas Kaiser
---
sysdeps/mach/hurd/bind.c | 2 +-
sysdeps/mach/hurd/connect.c | 2 +-
sysdeps/mach/hurd/sendto.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/sysdeps/mach/hurd/bind.c b/sysdeps/mach/hurd/bind.c
index a42b78a..996dc0b 100644
--- a/sysdeps/mach/hurd/bind.c
+++ b/sysdeps/mach/hurd/bind.c
@@ -101,7 +101,7 @@ __bind (int fd, __CONST_SOCKADDR_ARG addrarg, socklen_t
len)
return __hurd_fail (err);
}
else
- err = EIEIO;
+ return __hurd_fail (EIEIO);
err = HURD_DPORT_USE (fd,
({
diff --git a/sysdeps/mach/hurd/connect.c b/sysdeps/mach/hurd/connect.c
index 30883f6..cbba6c0 100644
--- a/sysdeps/mach/hurd/connect.c
+++ b/sysdeps/mach/hurd/connect.c
@@ -53,7 +53,7 @@ __connect (int fd, __CONST_SOCKADDR_ARG addrarg, socklen_t
len)
return __hurd_fail (err);
}
else
- err = EIEIO;
+ return __hurd_fail (EIEIO);
err = HURD_DPORT_USE (fd,
({
diff --git a/sysdeps/mach/hurd/sendto.c b/sysdeps/mach/hurd/sendto.c
index 478a5c9..18b1106 100644
--- a/sysdeps/mach/hurd/sendto.c
+++ b/sysdeps/mach/hurd/sendto.c
@@ -54,7 +54,7 @@ __sendto (int fd,
return __hurd_fail (err);
}
else
- err = EIEIO;
+ return __hurd_fail (EIEIO);
/* Get an address port for the desired destination address. */
err = HURD_DPORT_USE (fd,
--
1.7.2.2
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.