This is the mail archive of the
glibc-bugs@sourceware.org
mailing list for the glibc project.
[Bug libc/11754] RFE: dlopen of ET_EXEC file
- From: "pasky at suse dot cz" <sourceware-bugzilla at sourceware dot org>
- To: glibc-bugs at sources dot redhat dot com
- Date: 21 Sep 2010 14:17:16 -0000
- Subject: [Bug libc/11754] RFE: dlopen of ET_EXEC file
- References: <20100624232048.11754.jreiser@BitWagon.com>
- Reply-to: sourceware-bugzilla at sourceware dot org
------- Additional Comments From pasky at suse dot cz 2010-09-21 14:17 -------
The patch looks good to me! However, there are numerous style issues; the source
is usually aligned by opening parenthesis, and boolean operators are always at
the beginning of the next line. Also, I know why you use const == var, but
everywhere else var == const is used, so it would be better to stick with that.
The issues are in the second if condition, and I think the new mappref
initializer is also nearly unreadable now and would benefit from splitting to
multiple expressions.
--
http://sourceware.org/bugzilla/show_bug.cgi?id=11754
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.