This is the mail archive of the
gdb@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 0/2] MI: Add new command -complete
- From: Jan Vrany <jan dot vrany at fit dot cvut dot cz>
- To: Tom Tromey <tom at tromey dot com>
- Cc: gdb-patches at sourceware dot org, "gdb at sourceware dot org" <gdb at sourceware dot org>
- Date: Thu, 21 Feb 2019 16:05:21 +0000
- Subject: Re: [PATCH v2 0/2] MI: Add new command -complete
- References: <87imynm3ia.fsf@tromey.com> <20190128124101.26243-1-jan.vrany@fit.cvut.cz> <87pnrmnolt.fsf@tromey.com>
On Wed, 2019-02-20 at 14:20 -0700, Tom Tromey wrote:
> > > > > > "Jan" == Jan Vrany <jan.vrany@fit.cvut.cz> writes:
>
> Jan> respond with something like (proposed change):
>
> Jan> -complete "br m"
> Jan> =^done,text="br m",common="a",matches=["in", "dvise"]
>
> Jan> The rarionale is that frontend most likely needs these three
> Jan> values anyway to implement completion. It can, indeed compute
> Jan> them from full list as returned now, but GDB has these values
> Jan> already so it would save the frontend doing the same work again.
>
> Jan> OTOH, current output is more on par with CLI command output.
>
> Jan> What do you think?
>
> I think if this form seems more useful to MI users, then it's fine to
> implement it. I would say this is more important than making it similar
> to the CLI.
Are there any other GDB/MI users to comment on this? What would you prefer?
Jan