This is the mail archive of the gdb@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: GNU Tools Cauldron 2017 follow up: "Reviewed-by" etc.

From: Carlos O'Donell <carlos at redhat dot com>
To: Richard Biener <richard dot guenther at gmail dot com>, gcc at gcc dot gnu dot org, Thomas Schwinge <thomas at codesourcery dot com>, gdb at sourceware dot org, binutils at sourceware dot org, libc-alpha at sourceware dot org
Date: Thu, 21 Sep 2017 12:18:39 -0600
Subject: Re: GNU Tools Cauldron 2017 follow up: "Reviewed-by" etc.
Authentication-results: sourceware.org; auth=none
References: <87zi9oj8rl.fsf@euler.schwinge.homeip.net> <c713fc7a-d2ac-8e7f-0153-7ae24c992fee@redhat.com> <347AE883-971C-447C-AB07-43F7F70F25D3@gmail.com>

On 09/21/2017 11:56 AM, Richard Biener wrote:
>> Not yet.
> 
> I think given an OK from an official reviewer entitles you to commit
> it indeed IS matching the formal statement. It better does...

Isn't it better to be explicit about this; rather than assuming?

>> All of this is nothing compared to the work of doing the review.
> 
> Depends on the complexity of the patch...  

... depends on your ability to create quick paste hot keys :}

-- 
Cheers,
Carlos.

Follow-Ups:
- Re: GNU Tools Cauldron 2017 follow up: "Reviewed-by" etc.
  - From: Richard Biener
- Re: GNU Tools Cauldron 2017 follow up: "Reviewed-by" etc.
  - From: Thomas Schwinge

References:
- GNU Tools Cauldron 2017 follow up: "Reviewed-by" etc.
  - From: Thomas Schwinge
- Re: GNU Tools Cauldron 2017 follow up: "Reviewed-by" etc.
  - From: Carlos O'Donell
- Re: GNU Tools Cauldron 2017 follow up: "Reviewed-by" etc.
  - From: Richard Biener

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]