This is the mail archive of the
gdb@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 09/28] arm64/sve: Signal frame and context structure definition
- From: Dave Martin <Dave dot Martin at arm dot com>
- To: Catalin Marinas <catalin dot marinas at arm dot com>
- Cc: linux-arch at vger dot kernel dot org, libc-alpha at sourceware dot org, Ard Biesheuvel <ard dot biesheuvel at linaro dot org>, Szabolcs Nagy <szabolcs dot nagy at arm dot com>, gdb at sourceware dot org, Yao Qi <Yao dot Qi at arm dot com>, Will Deacon <will dot deacon at arm dot com>, Richard Sandiford <richard dot sandiford at arm dot com>, Alan Hayward <alan dot hayward at arm dot com>, Alex Bennée <alex dot bennee at linaro dot org>, kvmarm at lists dot cs dot columbia dot edu, linux-arm-kernel at lists dot infradead dot org
- Date: Wed, 13 Sep 2017 22:33:08 +0100
- Subject: Re: [PATCH v2 09/28] arm64/sve: Signal frame and context structure definition
- Authentication-results: sourceware.org; auth=none
- References: <1504198860-12951-1-git-send-email-Dave.Martin@arm.com> <1504198860-12951-10-git-send-email-Dave.Martin@arm.com> <20170913133618.lclorawve7364xxi@localhost>
On Wed, Sep 13, 2017 at 06:36:18AM -0700, Catalin Marinas wrote:
> On Thu, Aug 31, 2017 at 06:00:41PM +0100, Dave P Martin wrote:
> > +/*
> > + * The SVE architecture leaves space for future expansion of the
> > + * vector length beyond its initial architectural limit of 2048 bits
> > + * (16 quadwords).
> > + */
> > +#define SVE_VQ_BYTES 0x10 /* number of bytes per quadword */
> > +
> > +#define SVE_VQ_MIN 1
> > +#define SVE_VQ_MAX 0x200
>
> Just a nitpick (up to you): could you use 16 and 512 here instead of
> hex? I usually associate hex numbers with some bit fields.
I have no strong opinion other than a desire to make these constants
typo-proof.
There's no particular reason why these shouldn't be in decimal, so I can
change them if you like, provided you promise to notice if I misspell
512 as 521...
(git grep 131027)
Cheers
---Dave