This is the mail archive of the mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/2] gdbserver/xtensa: fix typo in XCHAL_HAVE_LOOPS

On Fri, Apr 17, 2015 at 2:29 PM, Pedro Alves <> wrote:
> On 04/17/2015 02:14 AM, Max Filippov wrote:
>> This fixes lbeg/lend/lcount registers handling through gdbserver.
>> 2015-04-17  Max Filippov  <>
>> gdb/gdbserver/
>>       * linux-xtensa-low.c (xtensa_fill_gregset,
>>       xtensa_store_gregset): fix typo in XCHAL_HAVE_LOOPS
> I was curious on whether it might have been that XCHAL_HAVE_LOOP
> used to exist and was later renamed ("as in, how did this ever work

It did work, only these three registers were inaccessible.

> then?"), but googling around, it doesn't seem have ever existed
> indeed.
> Write instead:
> 2015-04-17  Max Filippov  <>
> gdb/gdbserver/
>         * linux-xtensa-low.c (xtensa_fill_gregset)
>         (xtensa_store_gregset): Check XCHAL_HAVE_LOOPS instead
>         of XCHAL_HAVE_LOOP.
> OK with that change.

Ok. Can I check it in (I have write-after-approval access to binutils),
or do I need to request such access to gdb separately?

-- Max

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]