This is the mail archive of the
mailing list for the GDB project.
Re: Questions about code reviews and static analysis tools for TU Delft research
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Radjino Bholanath <R dot M dot R dot Bholanath at student dot tudelft dot nl>
- Cc: "gdb at sourceware dot org" <gdb at sourceware dot org>
- Date: Wed, 25 Feb 2015 08:57:58 +0100
- Subject: Re: Questions about code reviews and static analysis tools for TU Delft research
- Authentication-results: sourceware.org; auth=none
- References: <016900840D5AC640A0034E24ACD7F2600EE1931B at SRV366 dot tudelft dot net>
> 1. Do all developers (contributors and core developers) have to submit
> a code review for every change? Iâm asking because many projects only
> review changes made by contributors.
Changes considered obvious do not need to be reviewed.
Nominated maintainers have the right to push a change without prior
review, but most submit the change and give others some time to comment
on it before doing the push.
In all cases, whether it be an immediate push without review or not,
the patch is always posted in the gdb-patches mailing-list.
> 2. Which code review tools are used?
There is no code-review tool used. Patches are reviewed by answer
the email that was used to submit the patch.
There is a patch tracking tool used by some maintainers.
> 3. Are static analyzers used? If they are used:
> a. Is passing the checks of the static analyzers necessary for a change to be accepted?
> b. Which static analyzers are used?
No static analysis tool used by the project per se. We had some
reports from the past sent to us; and, when appropriate, we made
some adjustments based on those reports.