This is the mail archive of the
gdb@sourceware.org
mailing list for the GDB project.
Re: ChangeLogs in commit messages
- From: Gary Benson <gbenson at redhat dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: James Hogan <james dot hogan at imgtec dot com>, Doug Evans <dje at google dot com>, Sergio Durigan Junior <sergiodj at redhat dot com>, Andreas Schwab <schwab at linux-m68k dot org>, gdb <gdb at sourceware dot org>, Andreas Arnez <arnez at linux dot vnet dot ibm dot com>
- Date: Mon, 8 Sep 2014 16:30:47 +0100
- Subject: Re: ChangeLogs in commit messages
- Authentication-results: sourceware.org; auth=none
- References: <871trsuz55 dot fsf at igel dot home> <20140904090616 dot GA23758 at blade dot nx> <87y4tzcvny dot fsf at redhat dot com> <CADPb22ShAUeyzwpaLnTO4+ob=S1P2PyqD=4oN94fEx4ikNKUAw at mail dot gmail dot com> <20140904173624 dot GA10113 at blade dot nx> <20140905101324 dot GA3731 at blade dot nx> <CADPb22Sk7guAz5GTAPsKnKeq8=_x=_n7ecB8kPBXVmQE2GYvaw at mail dot gmail dot com> <20140908095029 dot GA24266 at blade dot nx> <540DAA52 dot 2000103 at imgtec dot com> <20140908132414 dot GK13931 at adacore dot com>
Joel Brobecker wrote:
> > IMHO this is a really bad idea.
>
> I wouldn't say "a really bad", but I tend to agree with the
> reasoning. It's a bit unnatural to me that git would chose to show
> the author date by default over the commit date, but James is right
> that the commit date is already there, and should largely reflect
> the date when the commit was pushed. Thanks to our daily updates of
> the BFD version, it's pretty much guaranteed that a contributor will
> always have to rebase before being able to push.
I don't really see the value of the author date in a rebase-based
workflow; by the time some series get committed I've folded tens if
not hundreds of commits into the "original" commits. But I don't
really mind either way. If people want people not to smush up the
dates then please remove the section I added to the wiki this morning.
Thanks,
Gary
--
http://gbenson.net/