This is the mail archive of the
gdb@sourceware.org
mailing list for the GDB project.
Re: ChangeLogs in commit messages
- From: James Hogan <james dot hogan at imgtec dot com>
- To: Gary Benson <gbenson at redhat dot com>, Doug Evans <dje at google dot com>
- Cc: Sergio Durigan Junior <sergiodj at redhat dot com>, Andreas Schwab <schwab at linux-m68k dot org>, Joel Brobecker <brobecker at adacore dot com>, gdb <gdb at sourceware dot org>, Andreas Arnez <arnez at linux dot vnet dot ibm dot com>
- Date: Mon, 8 Sep 2014 14:21:39 +0100
- Subject: Re: ChangeLogs in commit messages
- Authentication-results: sourceware.org; auth=none
- References: <20140814125224 dot GF4924 at adacore dot com> <8761h4fmu4 dot fsf at redhat dot com> <87mwage6x2 dot fsf at redhat dot com> <871trsuz55 dot fsf at igel dot home> <20140904090616 dot GA23758 at blade dot nx> <87y4tzcvny dot fsf at redhat dot com> <CADPb22ShAUeyzwpaLnTO4+ob=S1P2PyqD=4oN94fEx4ikNKUAw at mail dot gmail dot com> <20140904173624 dot GA10113 at blade dot nx> <20140905101324 dot GA3731 at blade dot nx> <CADPb22Sk7guAz5GTAPsKnKeq8=_x=_n7ecB8kPBXVmQE2GYvaw at mail dot gmail dot com> <20140908095029 dot GA24266 at blade dot nx> <540DAA52 dot 2000103 at imgtec dot com>
On 08/09/14 14:08, James Hogan wrote:
> On 08/09/14 10:50, Gary Benson wrote:
>> Doug Evans wrote:
>>> On Fri, Sep 5, 2014 at 3:13 AM, Gary Benson <gbenson@redhat.com> wrote:
>>>> Gary Benson wrote:
>>>>> Doug Evans wrote:
>>>>>> If I do a git blame of server.c I see patch 860789c7 with a
>>>>>> date of 2014-08-08. That's three weeks before it was pushed
>>>>>> upstream. Bleah. I'd really like to be able to do a git
>>>>>> blame and have what I see be useful, including the date. The
>>>>>> author date is basically useless to me.
>>>>>
>>>>> I see some options to git-rebase, --committer-date-is-author-date
>>>>> and --ignore-date. I'll experiment with these the next time I
>>>>> rebase something and see what happens.
>>>>
>>>> Running "git rebase --ignore-date gdb/master" immediately prior to
>>>> pushing sets both author and commit dates to the present time on
>>>> all commits you are about to push.
>>>
>>> Cool. Can you add that to the contribution checklist?
>>
>> https://sourceware.org/gdb/wiki/ContributionChecklist#Fixing_commit_dates
>>
>> If we add a server-side hook to check that the ChangeLog messages in
>> the commit messages are correct we could also use that hook to check
>> that the dates in commits match the dates in the ChangeLog files.
>
> IMHO this is a really bad idea.
Just to clarify, I'm not referring to the adding of a hook, but the
rebase with --ignore-date. :-)
Cheers
James