This is the mail archive of the
mailing list for the GDB project.
Re: Patchwork patch tracking system
- From: Pedro Alves <palves at redhat dot com>
- To: Eli Zaretskii <eliz at gnu dot org>
- Cc: tromey at redhat dot com, brobecker at adacore dot com, gbenson at redhat dot com, stanshebs at earthlink dot net, gdb at sourceware dot org
- Date: Wed, 21 May 2014 22:35:04 +0100
- Subject: Re: Patchwork patch tracking system
- Authentication-results: sourceware.org; auth=none
- References: <20140402100842 dot GA956 at blade dot nx> <533F3713 dot 40700 at earthlink dot net> <20140417135040 dot GA891 at blade dot nx> <20140422130652 dot GG5790 at adacore dot com> <8738gw6p4b dot fsf at fleche dot redhat dot com> <87tx8jnq7j dot fsf at fleche dot redhat dot com> <537CDFCE dot 7000407 at redhat dot com> <83wqdfm2l9 dot fsf at gnu dot org>
On 05/21/2014 07:03 PM, Eli Zaretskii wrote:
>> Date: Wed, 21 May 2014 18:18:06 +0100
>> From: Pedro Alves <email@example.com>
>> CC: Gary Benson <firstname.lastname@example.org>, Stan Shebs <email@example.com>, firstname.lastname@example.org
>> The fact that the ChangeLog is usually not a part of the patch
>> and then is added before push changes the hash.
> But that's just for historical reasons, right? If we use
> git-changelog-merge, there should be no reason not to make ChangeLog
> changes part of the patch, right?
Right, but still, but if that merge actually changes the patch,
because it puts the ChangeLog entry at the top of the file, and
the top commit is no longer the same as was when the patch was
generated for submission (frequently true), then the hash changes.