This is the mail archive of the gdb@sourceware.org mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
v2 set attached. Specific comments below but all should be addressed EXCEPT the one on tabs in mips/configure.ac because that is consistent with the code already there. common/acinclude.m4 seems to use two spaces. if you want to switch tabs to two spaces on the head after this is resolved, I will do that. But I am just trying to resolve this before the deadline. FYI I did not build as much this time. Only mipstx39-elf, frv-elf, mips-elf, and bfin-elf with enable/disable sim hardware. If this needs adjustment, please let me know. In a few hours, I am heading off for the weekend. Otherwise, please commit to both the branch and head. Thanks. --joel On 3/21/2013 7:33 PM, Mike Frysinger wrote:
On Thursday 21 March 2013 11:53:13 Joel Sherrill wrote:Per conversations with Mike Frysinger, I have made other modifications. These basically address: + simulators which can't work without dv-sockser.o fail at configuration + simulators which fail with --disable-sim-hardware fail at configuration + added conditionals and FIXME for dv-sockser.o references in source Attached is a tarball from git which has a patch per simulator directory touched. The last patch is the regeneration of configure's. I have built all of the impacted CPUs with --enable-sim-hardware and --disable-sim-hardware.the main idea looks good to me. just style nits below.0001-sim-common-acinclude.m4-Address-always-required-hard.patch + if test "[$1]" = "always"; then + AC_MSG_ERROR([Sorry, but this simulator requires that hardware supportbe enabled. Please configure without --disable-hw-support.])
Broken into multiple lines.
+ fithat line is too long. just put a new line in the middle and that should be fine (since the output will still look fine). AC_MSG_ERROR([................... ............])
Broken into multiple lines.
0002-bfin-configure.ac-Address-use-of-dv-sockser.o.patch +2013-03-20 Joel Sherrill <joel.sherrill@oarcorp.com>should be two spaces between your name & e-mail. you should check all the ChangeLog entries accordingly.
Fixed.
+ * configure.ac: Use $SIM_DV_SOCKSER_Oshould have a period at the end. you should check all the ChangeLog entries accordingly.
I think all of these are fixed.:e miop
0003-sim-mips-Address-use-of-dv-sockser.o.patch + AC_MSG_ERROR([Sorry, but tx3904sio hardware support is unavailablefor your target. Please use --disable-sim-hardware, or pass a list of devices to enable that does not include that.]) same comment re-too long of a line.
Fixed.
also, i think this indents with a tab instead of two spaces ? a few of the patches have that, so you should grep for tabs to make sure none are left in.
This file uses tabs for indents which is different from common/acinclude.m4 which was using two spaces. I just followed the existing code.
0005-frv-configure.ac-Address-use-of-dv-sockser.o.patch + AC_MSG_ERROR([Sorry, but hardware support in this simulatorunconditionally relies on dv-sockser.o, it is unavailable for your host. Please fix this simulator.]) same comment about too long. also, change "..., it is" to "... which is".
Done.
0006-iq2000-configure.ac-Address-use-of-dv-sockser.o.patch 0007-m32r-configure.ac-Address-use-of-dv-sockser.o.patch 0008-mn10300-configure.ac-Address-use-of-dv-sockser.o.patch 0009-sh64-configure.ac-Address-use-of-dv-sockser.o.patchsame feedback as 0005-frv patch above
All should be fixed.
-mike
-- Joel Sherrill, Ph.D. Director of Research & Development joel.sherrill@OARcorp.com On-Line Applications Research Ask me about RTEMS: a free RTOS Huntsville AL 35805 Support Available (256) 722-9985
Attachment:
to_gdb_v2.tar.bz2
Description: Binary data
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |