This is the mail archive of the
gdb@sourceware.org
mailing list for the GDB project.
Re: [ARI] Status of ATTRIBUTE_UNUSED in gdb sources
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Pierre Muller <pierre dot muller at ics-cnrs dot unistra dot fr>
- Cc: gdb at sourceware dot org, gdb-patches at sourceware dot org
- Date: Tue, 4 May 2010 08:37:52 -0700
- Subject: Re: [ARI] Status of ATTRIBUTE_UNUSED in gdb sources
- References: <002701caeb90$894ad040$9be070c0$@muller@ics-cnrs.unistra.fr>
> Is this comment still valid, from the compiler point of view?
> Does gcc still have such problems?
I don't know.
> If yes, is it OK if I remove all ATTRIBUTE_UNUSED from sources?
> If no, shouldn't we change that policy?
I haven't thought much about it but, to me ATTRIBUTE_UNUSED does not
make sense unless we use -Wunused-param. And I really don't see how
this switch could help us increase code quality - only extra hassle
trying to silence warnings. We have so many functions used as callbacks
with defined APIs that we probably have unused parameters everywhere.
So, at this point, I'm leaning towards getting rid of ATTRIBUTE_UNUSED
and keeping the ARI (or perhaps poison it too).
--
Joel